public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Aneesh Kumar KV <aneesh.kumar@linux.vnet.ibm.com>,
	Balbir Singh <balbir@in.ibm.com>
Subject: Re: VolanoMark regression with 2.6.27-rc1
Date: Wed, 20 Aug 2008 15:24:49 +0800	[thread overview]
Message-ID: <1219217089.8781.27.camel@ymzhang> (raw)
In-Reply-To: <20080818052155.GA5063@linux.vnet.ibm.com>


On Mon, 2008-08-18 at 10:51 +0530, Dhaval Giani wrote: 
> > > > > > So with kernel 2.6.27-rc1, the successful wakeup_affine is about
> > > > > > double of the one of 2.6.27-rc1
> > > > > > on domain 0, but about 10 times on domain 1. That means more tasks are
> > > > > > woken up on waker cpus.
> > > > > > 
> > > > > > Does that mean it doesn't follow cache-hot checking?
> > > > > 
> > > > > I'm a bit puzzled, but you're right - I too noticed that volanomark is
> > > > > _very_ sensitive to affine wakeups.
> > > > > 
> > > > > I'll try and find what changed in that code for GROUP=n.
> > > > 
> > > > hi Yanmin,
> > > > 
> > > > I was wondering if you could send me your config and what sysctls you
> > > > have set. I have not been able to reproduce the 2.6.26 -> 2.6.27-rc1
> > > > GROUP=n regression.
> > > Pls. see the attachment. As for sysctl, I just set /proc/sys/kernel/sched_compat_yield=1.
> > > 
> > > I am wondering if the load balance causes the regression when group=n. I manually delete
> > > all GROUP codes and do a diff against 26 and 27-rc1.
> > > 
> > 
> > You can disable load balancing by being in uniprocessor mode.
> > 
> 
> Hi,
> 
> I can see this regression only with sched_compat_yield=1. Some numbers
> though, I see a 5% regression with max_cpus=1 whereas close to 50% with
> SMP on a 8 way.
After reverting below patch, volanoMark regression becomes less than 2% with CONFIG_GROUP_SCHED=n
on my 8-core stoakely. The improvement on 16-core tigerton is about 44%, but there is still about
 20% regression, comparing with 2.6.26_nogroup.


commit 93b75217df39e6d75889cc6f8050343286aff4a5
Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date:   Fri Jun 27 13:41:33 2008 +0200

    sched: disable source/target_load bias
    
    The bias given by source/target_load functions can be very large, disable
    it by default to get faster convergence.
    
    Signed-off-by: Peter Zijlstra <peterz@infradead.org>
    Cc: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>



This patch adds a new feature LB_BIAS, but uses it with a NOT, so I lost it when I tested
single sched feature one by one. That also explains why wake_affine and load_balance_newidle
have more successful task pulling with kernel 2.6.27-rc, because MC and CPU domain's wake_idx
is 1, so this patch has impact on them.

Dhaval, could you test it on your 8-way machine?

> 
> Peter do you have any patches already, which I can try?
> 
> Thanks,


  parent reply	other threads:[~2008-08-20  7:26 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31  3:20 VolanoMark regression with 2.6.27-rc1 Zhang, Yanmin
2008-07-31  7:31 ` Zhang, Yanmin
2008-07-31  7:39   ` Peter Zijlstra
2008-07-31  7:49     ` Zhang, Yanmin
2008-08-01  0:39       ` Zhang, Yanmin
2008-08-01  2:35         ` Miao Xie
2008-08-01  3:08           ` Zhang, Yanmin
2008-08-01  5:14         ` Dhaval Giani
2008-08-04  5:04           ` Zhang, Yanmin
2008-08-04  5:22             ` Dhaval Giani
2008-08-04  5:37               ` Zhang, Yanmin
2008-08-04  5:53                 ` Dhaval Giani
2008-08-04  6:26                   ` Peter Zijlstra
2008-08-04  6:26                   ` Peter Zijlstra
2008-08-04  7:05                     ` Dhaval Giani
2008-08-04  7:12                       ` Peter Zijlstra
2030-08-06  3:26                         ` Zhang, Yanmin
2008-08-08  7:30                           ` Peter Zijlstra
     [not found]                             ` <20080811185008.GA29291@linux.vnet.ibm.com>
     [not found]                               ` <1912726331.25608.235.camel@ymzhang>
     [not found]                                 ` <20080817115035.GA32223@linux.vnet.ibm.com>
     [not found]                                   ` <20080818052155.GA5063@linux.vnet.ibm.com>
2008-08-20  7:24                                     ` Zhang, Yanmin [this message]
2008-08-20  7:41                                       ` Peter Zijlstra
2008-08-20 10:51                                         ` Ingo Molnar
2008-08-20 13:32                                           ` Peter Zijlstra
2008-08-20 13:47                                             ` Ingo Molnar
2008-08-21  2:25                                               ` Zhang, Yanmin
2008-08-21  6:16                                                 ` Ingo Molnar
2008-08-21  6:48                                                   ` Zhang, Yanmin
2008-08-29  3:35                                                     ` Zhang, Yanmin
2008-08-29  3:38                                                       ` Zhang, Yanmin
2008-08-20 14:32                                             ` adobriyan
2008-08-20 14:33                                               ` Peter Zijlstra
2008-08-20 15:10                                                 ` Nick Piggin
2008-08-20 15:15                                                   ` Peter Zijlstra
2008-08-20 16:29                                                   ` Ray Lee
2008-08-20 16:51                                                     ` Peter Zijlstra
2008-08-20 17:21                                                     ` Peter Zijlstra
2008-08-20 17:55                                                       ` Nick Piggin
2008-08-20 18:15                                                         ` Ray Lee
2008-08-20 20:30                                                           ` Peter Zijlstra
2008-08-20 20:56                                                             ` Peter Zijlstra
2008-08-21  6:11                                                               ` Nick Piggin
2008-08-21  8:17                                                                 ` Peter Zijlstra
2008-08-21  6:15                                                               ` Ingo Molnar
2008-08-20 20:58                                                             ` Ray Lee
2008-08-20 21:04                                                               ` Peter Zijlstra
2008-08-21  6:12                                                       ` Ingo Molnar
2030-08-13  8:50                             ` Zhang, Yanmin
2008-08-04  6:54                   ` Peter Zijlstra
2008-08-15 15:37                     ` Ingo Molnar
2008-08-01 12:25 ` Hugh Dickins
2008-08-04  0:54   ` Zhang, Yanmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219217089.8781.27.camel@ymzhang \
    --to=yanmin_zhang@linux.intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=balbir@in.ibm.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox