From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>, Kay Sievers <kay.sievers@vrfy.org>
Subject: [PATCH 08/15] driver core: add init_name to struct device
Date: Thu, 21 Aug 2008 10:32:56 -0700 [thread overview]
Message-ID: <1219339983-9634-8-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20080821173036.GB7974@suse.de>
This gives us a way to handle both the bus_id and init_name values being
used for a while during the transition period.
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/base/core.c | 20 +++++++++++++-------
include/linux/device.h | 1 +
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 4004131..d021c98 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -844,13 +844,19 @@ int device_add(struct device *dev)
{
struct device *parent = NULL;
struct class_interface *class_intf;
- int error;
+ int error = -EINVAL;
dev = get_device(dev);
- if (!dev || !strlen(dev->bus_id)) {
- error = -EINVAL;
- goto Done;
- }
+ if (!dev)
+ goto done;
+
+ /* Temporarily support init_name if it is set.
+ * It will override bus_id for now */
+ if (dev->init_name)
+ dev_set_name(dev, "%s", dev->init_name);
+
+ if (!strlen(dev->bus_id))
+ goto done;
pr_debug("device: '%s': %s\n", dev->bus_id, __func__);
@@ -919,7 +925,7 @@ int device_add(struct device *dev)
class_intf->add_dev(dev, class_intf);
mutex_unlock(&dev->class->p->class_mutex);
}
- Done:
+done:
put_device(dev);
return error;
DPMError:
@@ -946,7 +952,7 @@ int device_add(struct device *dev)
cleanup_device_parent(dev);
if (parent)
put_device(parent);
- goto Done;
+ goto done;
}
/**
diff --git a/include/linux/device.h b/include/linux/device.h
index a701c1b..4d8372d 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -358,6 +358,7 @@ struct device {
struct kobject kobj;
char bus_id[BUS_ID_SIZE]; /* position on parent bus */
+ const char *init_name; /* initial name of the device */
struct device_type *type;
unsigned uevent_suppress:1;
--
1.5.6.5
next prev parent reply other threads:[~2008-08-21 17:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 17:30 [GIT PATCH] driver core patches against 2.6.26-rc4 Greg KH
2008-08-21 17:32 ` [PATCH 01/15] kobject: Replace ALL occurrences of '/' with '!' instead of only the first one Greg Kroah-Hartman
2008-08-22 12:41 ` Ville Syrjälä
2008-08-23 2:14 ` Greg KH
2008-08-21 17:32 ` [PATCH 02/15] Japanese translation of Documentation/SubmitChecklist Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 03/15] Documentation: HOWTO-ja_JP-sync patch Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 04/15] drivers/base/driver.c: remove unused to_dev() macro Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 05/15] dev_printk(): constify the `dev' argument Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 06/15] driver model: anti-oopsing medicine Greg Kroah-Hartman
2008-08-21 18:24 ` David Brownell
2008-08-21 20:04 ` Greg KH
2008-08-21 17:32 ` [PATCH 07/15] PM: don't skip device PM init when CONFIG_PM_SLEEP isn't set and CONFIG_PM is set Greg Kroah-Hartman
2008-08-21 17:32 ` Greg Kroah-Hartman [this message]
2008-08-21 17:32 ` [PATCH 09/15] PM: Remove WARN_ON from device_pm_add Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 10/15] block: fix partial read() of /proc/{partitions,diskstats} Greg Kroah-Hartman
2008-08-21 17:32 ` [PATCH 11/15] block: drop references taken by class_find_device() Greg Kroah-Hartman
2008-08-21 17:33 ` [PATCH 12/15] UIO: uio_pdrv: fix memory leak Greg Kroah-Hartman
2008-08-21 17:33 ` [PATCH 13/15] UIO: uio_pdrv: fix license specification Greg Kroah-Hartman
2008-08-21 17:33 ` [PATCH 14/15] UIO: generic irq handling for some uio platform devices Greg Kroah-Hartman
2008-08-21 17:33 ` [PATCH 15/15] pnp: fix "add acpi:* modalias entries" Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219339983-9634-8-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox