From: Alok Kataria <akataria@vmware.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
davej <davej@codemonkey.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [BUG] cpufreq: constant cpu_khz
Date: Mon, 25 Aug 2008 10:34:35 -0700 [thread overview]
Message-ID: <1219685675.1979.5.camel@alok-dev1> (raw)
In-Reply-To: <20080825123926.GC8663@elte.hu>
On Mon, 2008-08-25 at 05:39 -0700, Ingo Molnar wrote:
> * Peter Zijlstra <peterz@infradead.org> wrote:
>
> > > I noticed that my sched_clock() was slow on a number of machine, so
> > > I started looking at cpufreq.
> >
> > The below seems to fix the problem for me, but I don't have enough
> > clue to know if its the correct fix, please advise.
>
> > - set_cyc2ns_scale(tsc_khz_ref, freq->cpu);
> > + set_cyc2ns_scale(tsc_khz, freq->cpu);
>
> hm, that too is due to the tsc.c unification - Alok Cc:-ed. Applied your
> fix to x86/urgent.
>
Yes the fix is correct, tsc_khz can change in the loop above.
Looking at tsc_64.c before the integration, that too had this bug but
32bit was good. So this is the right fix.
Thanks,
Alok
> Ingo
next prev parent reply other threads:[~2008-08-25 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 6:33 [BUG] cpufreq: constant cpu_khz Peter Zijlstra
2008-08-25 11:35 ` Peter Zijlstra
2008-08-25 12:39 ` Ingo Molnar
2008-08-25 17:34 ` Alok Kataria [this message]
2008-08-25 17:55 ` Dave Jones
2008-08-25 17:57 ` Ingo Molnar
2008-08-25 18:22 ` Arjan van de Ven
2008-08-25 19:27 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219685675.1979.5.camel@alok-dev1 \
--to=akataria@vmware.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox