From: Harvey Harrison <harvey.harrison@gmail.com>
To: "Paul E. McKenney" <paulmck@us.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] rcu: spinlocks take an unsigned long flags
Date: Tue, 26 Aug 2008 13:00:44 -0700 [thread overview]
Message-ID: <1219780844.6069.5.camel@brick> (raw)
Noticed by sparse:
kernel/rcuclassic.c:719:2: error: incompatible types in comparison expression (different signedness)
kernel/rcuclassic.c:727:2: error: incompatible types in comparison expression (different signedness)
kernel/rcuclassic.c: In function ‘rcu_init_percpu_data’:
kernel/rcuclassic.c:719: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:727: warning: comparison of distinct pointer types lacks a cast
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
kernel/rcuclassic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
index 3f69189..743cf05 100644
--- a/kernel/rcuclassic.c
+++ b/kernel/rcuclassic.c
@@ -714,7 +714,7 @@ void rcu_check_callbacks(int cpu, int user)
static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp,
struct rcu_data *rdp)
{
- long flags;
+ unsigned long flags;
spin_lock_irqsave(&rcp->lock, flags);
memset(rdp, 0, sizeof(*rdp));
--
1.6.0.340.g84854
next reply other threads:[~2008-08-26 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 20:00 Harvey Harrison [this message]
2008-08-26 20:45 ` [PATCH 1/2] rcu: spinlocks take an unsigned long flags Paul E. McKenney
2008-08-26 20:52 ` Harvey Harrison
2008-08-26 21:43 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219780844.6069.5.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox