[PATCH 1/2] rcu: spinlocks take an unsigned long flags

[PATCH 1/2] rcu: spinlocks take an unsigned long flags

[Harvey Harrison]

Noticed by sparse:
kernel/rcuclassic.c:719:2: error: incompatible types in comparison expression (different signedness)
kernel/rcuclassic.c:727:2: error: incompatible types in comparison expression (different signedness)
kernel/rcuclassic.c: In function ‘rcu_init_percpu_data’:
kernel/rcuclassic.c:719: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:727: warning: comparison of distinct pointer types lacks a cast

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 kernel/rcuclassic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
index 3f69189..743cf05 100644
--- a/kernel/rcuclassic.c
+++ b/kernel/rcuclassic.c
@@ -714,7 +714,7 @@ void rcu_check_callbacks(int cpu, int user)
 static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp,
 						struct rcu_data *rdp)
 {
-	long flags;
+	unsigned long flags;
 
 	spin_lock_irqsave(&rcp->lock, flags);
 	memset(rdp, 0, sizeof(*rdp));
-- 
1.6.0.340.g84854

Re: [PATCH 1/2] rcu: spinlocks take an unsigned long flags

[Paul E. McKenney]

On Tue, Aug 26, 2008 at 01:00:44PM -0700, Harvey Harrison wrote:
> Noticed by sparse:
> kernel/rcuclassic.c:719:2: error: incompatible types in comparison expression (different signedness)
> kernel/rcuclassic.c:727:2: error: incompatible types in comparison expression (different signedness)
> kernel/rcuclassic.c: In function ‘rcu_init_percpu_data’:
> kernel/rcuclassic.c:719: warning: comparison of distinct pointer types lacks a cast
> kernel/rcuclassic.c:727: warning: comparison of distinct pointer types lacks a cast

This is a duplicate of http://lkml.org/lkml/2008/8/18/497, sent in
by Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>.

							Thanx, Paul

> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
>  kernel/rcuclassic.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
> index 3f69189..743cf05 100644
> --- a/kernel/rcuclassic.c
> +++ b/kernel/rcuclassic.c
> @@ -714,7 +714,7 @@ void rcu_check_callbacks(int cpu, int user)
>  static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp,
>  						struct rcu_data *rdp)
>  {
> -	long flags;
> +	unsigned long flags;
> 
>  	spin_lock_irqsave(&rcp->lock, flags);
>  	memset(rdp, 0, sizeof(*rdp));
> -- 
> 1.6.0.340.g84854
> 
> 

Re: [PATCH 1/2] rcu: spinlocks take an unsigned long flags

[Harvey Harrison]

On Tue, 2008-08-26 at 13:45 -0700, Paul E. McKenney wrote:
> On Tue, Aug 26, 2008 at 01:00:44PM -0700, Harvey Harrison wrote:
> > Noticed by sparse:
> > kernel/rcuclassic.c:719:2: error: incompatible types in comparison expression (different signedness)
> > kernel/rcuclassic.c:727:2: error: incompatible types in comparison expression (different signedness)
> > kernel/rcuclassic.c: In function ‘rcu_init_percpu_data’:
> > kernel/rcuclassic.c:719: warning: comparison of distinct pointer types lacks a cast
> > kernel/rcuclassic.c:727: warning: comparison of distinct pointer types lacks a cast
> 
> This is a duplicate of http://lkml.org/lkml/2008/8/18/497, sent in
> by Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>.
> 

Ok, what tree is it going in through, this was from today's linux-next.

Harvey

Re: [PATCH 1/2] rcu: spinlocks take an unsigned long flags

[Paul E. McKenney]

On Tue, Aug 26, 2008 at 01:52:11PM -0700, Harvey Harrison wrote:
> On Tue, 2008-08-26 at 13:45 -0700, Paul E. McKenney wrote:
> > On Tue, Aug 26, 2008 at 01:00:44PM -0700, Harvey Harrison wrote:
> > > Noticed by sparse:
> > > kernel/rcuclassic.c:719:2: error: incompatible types in comparison expression (different signedness)
> > > kernel/rcuclassic.c:727:2: error: incompatible types in comparison expression (different signedness)
> > > kernel/rcuclassic.c: In function ‘rcu_init_percpu_data’:
> > > kernel/rcuclassic.c:719: warning: comparison of distinct pointer types lacks a cast
> > > kernel/rcuclassic.c:727: warning: comparison of distinct pointer types lacks a cast
> > 
> > This is a duplicate of http://lkml.org/lkml/2008/8/18/497, sent in
> > by Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>.
> > 
> 
> Ok, what tree is it going in through, this was from today's linux-next.

Good question -- my guess would be tip/core/rcu, but either way, it
should be added somewhere.  ;-)

							Thanx, Paul