From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: printk_time to use tsc before cpu_clock is ready
Date: Wed, 27 Aug 2008 09:47:13 +0200 [thread overview]
Message-ID: <1219823233.6462.38.camel@twins> (raw)
In-Reply-To: <20080827074230.GA20993@elte.hu>
On Wed, 2008-08-27 at 09:42 +0200, Ingo Molnar wrote:
> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>
> > +static unsigned long long tsc_clock(int cpu)
> > +{
> > + unsigned long long t;
> > +
> > + rdtscll(t);
> > +
> > + return t;
> > +}
>
> hm, i'm not sure i like the whole direction - this reintroduces
> printk_clock in essence.
>
> how about initializing cpu_clock() sooner, so that printk timestamps
> start ticking as soon as possible?
which will make some archs quite unhappy iirc, see those arm and ia64
bugs I caused the other day.
next prev parent reply other threads:[~2008-08-27 7:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 7:38 [PATCH] printk_time: prepare stub for using other than cpu_clock Yinghai Lu
2008-08-27 7:38 ` [PATCH] x86: printk_time to use tsc before cpu_clock is ready Yinghai Lu
2008-08-27 7:42 ` Ingo Molnar
2008-08-27 7:47 ` Peter Zijlstra [this message]
2008-08-27 8:02 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2008-07-29 10:08 [PATCH] printk_time: prepare stub for using other than cpu_clock Yinghai Lu
2008-07-29 10:09 ` [PATCH] x86: printk_time to use tsc before cpu_clock is ready Yinghai Lu
2008-07-29 10:13 ` Peter Zijlstra
2008-07-29 10:18 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219823233.6462.38.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox