From: Grzegorz Nosek <grzegorz.nosek@gmail.com>
To: Chris Wright <chrisw@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sys_sendfile oops in 2.6.13?
Date: Wed, 12 Oct 2005 22:06:57 +0200 [thread overview]
Message-ID: <121a28810510121306j368acd9ei@mail.gmail.com> (raw)
In-Reply-To: <20051012173830.GP7991@shell0.pdx.osdl.net>
2005/10/12, Chris Wright <chrisw@osdl.org>:
> * Grzegorz Nosek (grzegorz.nosek@gmail.com) wrote:
> > --- linux-2.6/fs/read_write.c~ 2005-10-06 21:35:03.000000000 +0200
> > +++ linux-2.6/fs/read_write.c 2005-10-05 19:14:04.000000000 +0200
> > @@ -719,7 +719,7 @@
> > current->syscr++;
> > current->syscw++;
> >
> > - if (*ppos > max)
> > + if (ppos && *ppos > max)
> > retval = -EOVERFLOW;
>
> This doesn't make sense. ppos must not be NULL.
>
> Code looks like this:
>
> if (!ppos)
> ppos = &in_file->f_pos;
> ...
> pos = *ppos;
> ...
> if (*ppos > max)
>
> So it can't be NULL, and if somehow it were, the oops would've already
> happened.
>
Yeah, I know. It turned out to be a 3rd-party patch (vserver
probably). My read_write.c looks very different and somehow I
overlooked that while checking with vanilla 2.6.13.3. Sorry for the
confusion.
Regards,
Greg
prev parent reply other threads:[~2005-10-12 22:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-11 8:56 sys_sendfile oops in 2.6.13? Grzegorz Nosek
2005-10-11 14:53 ` Jiri Slaby
2005-10-12 4:00 ` Andy Isaacson
2005-10-12 9:11 ` Grzegorz Nosek
2005-10-12 17:38 ` Chris Wright
2005-10-12 20:06 ` Grzegorz Nosek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=121a28810510121306j368acd9ei@mail.gmail.com \
--to=grzegorz.nosek@gmail.com \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox