Re: [PATCH v5 18/25] powerpc/pseries: Log hcall return codes for PLPKS debug

Stefan Berger
2023-01-31T16:32:19Z

On 1/31/23 01:39, Andrew Donnellan wrote:
> From: Russell Currey <ruscur@russell.cc>
>
> The plpks code converts hypervisor return codes into their Linux
> equivalents so that users can understand them. Having access to the
> original return codes is really useful for debugging, so add a
> pr_debug() so we don't lose information from the conversion.
>
> Signed-off-by: Russell Currey <ruscur@russell.cc>
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>

> ---
> arch/powerpc/platforms/pseries/plpks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
> index cee06fb9a370..e5755443d4a4 100644
> --- a/arch/powerpc/platforms/pseries/plpks.c
> +++ b/arch/powerpc/platforms/pseries/plpks.c
> @@ -117,6 +117,8 @@ static int pseries_status_to_err(int rc)
> err = -EINVAL;
> }
>
> + pr_debug("Converted hypervisor code %d to Linux %d\n", rc, err);
> +
> return err;
> }
>