* [PATCH] alsa: ac97_patch make functions static
@ 2008-08-29 20:32 Harvey Harrison
2008-09-01 6:39 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-08-29 20:32 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Andrew Morton, LKML
Only used in ac97_codec by including ac97_patch.c directly, effectively static
Found by sparse:
sound/pci/ac97/ac97_patch.c:3551:5: warning: symbol 'patch_vt1617a' was not declared. Should it be static?
sound/pci/ac97/ac97_patch.c:3767:5: warning: symbol 'patch_vt1618' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
sound/pci/ac97/ac97_patch.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
index d0cab1d..6ce3cbe 100644
--- a/sound/pci/ac97/ac97_patch.c
+++ b/sound/pci/ac97/ac97_patch.c
@@ -3548,7 +3548,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1617a[] = {
},
};
-int patch_vt1617a(struct snd_ac97 * ac97)
+static int patch_vt1617a(struct snd_ac97 * ac97)
{
int err = 0;
int val;
@@ -3764,7 +3764,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1618[] = {
}
};
-int patch_vt1618(struct snd_ac97 *ac97)
+static int patch_vt1618(struct snd_ac97 *ac97)
{
return patch_build_controls(ac97, snd_ac97_controls_vt1618,
ARRAY_SIZE(snd_ac97_controls_vt1618));
--
1.6.0.366.gf9ffa8
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] alsa: ac97_patch make functions static
2008-08-29 20:32 [PATCH] alsa: ac97_patch make functions static Harvey Harrison
@ 2008-09-01 6:39 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-09-01 6:39 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Andrew Morton, LKML
At Fri, 29 Aug 2008 13:32:00 -0700,
Harvey Harrison wrote:
>
> Only used in ac97_codec by including ac97_patch.c directly, effectively static
>
> Found by sparse:
> sound/pci/ac97/ac97_patch.c:3551:5: warning: symbol 'patch_vt1617a' was not declared. Should it be static?
> sound/pci/ac97/ac97_patch.c:3767:5: warning: symbol 'patch_vt1618' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Thanks, applied now.
Takashi
> ---
> sound/pci/ac97/ac97_patch.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
> index d0cab1d..6ce3cbe 100644
> --- a/sound/pci/ac97/ac97_patch.c
> +++ b/sound/pci/ac97/ac97_patch.c
> @@ -3548,7 +3548,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1617a[] = {
> },
> };
>
> -int patch_vt1617a(struct snd_ac97 * ac97)
> +static int patch_vt1617a(struct snd_ac97 * ac97)
> {
> int err = 0;
> int val;
> @@ -3764,7 +3764,7 @@ static const struct snd_kcontrol_new snd_ac97_controls_vt1618[] = {
> }
> };
>
> -int patch_vt1618(struct snd_ac97 *ac97)
> +static int patch_vt1618(struct snd_ac97 *ac97)
> {
> return patch_build_controls(ac97, snd_ac97_controls_vt1618,
> ARRAY_SIZE(snd_ac97_controls_vt1618));
> --
> 1.6.0.366.gf9ffa8
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-01 6:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-29 20:32 [PATCH] alsa: ac97_patch make functions static Harvey Harrison
2008-09-01 6:39 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox