From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Avi Kivity <avi@qumranet.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH] sched_clock: fix NOHZ interaction
Date: Mon, 01 Sep 2008 16:58:08 +0200 [thread overview]
Message-ID: <1220281088.8426.63.camel@twins> (raw)
In-Reply-To: <48BABC19.1060509@qumranet.com>
Avi, the below fixes it for me..
---
Subject: sched_clock: fix NOHZ interaction
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Mon Sep 01 16:44:23 CEST 2008
If HLT stops the TSC, we'll fail to account idle time, thereby inflating the
actual process times. Fix this by re-calibrating the clock against GTOD when
leaving nohz mode.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/time/tick-sched.c | 3 +++
1 file changed, 3 insertions(+)
Index: linux-2.6/kernel/time/tick-sched.c
===================================================================
--- linux-2.6.orig/kernel/time/tick-sched.c
+++ linux-2.6/kernel/time/tick-sched.c
@@ -162,6 +162,8 @@ void tick_nohz_stop_idle(int cpu)
ts->idle_lastupdate = now;
ts->idle_sleeptime = ktime_add(ts->idle_sleeptime, delta);
ts->idle_active = 0;
+
+ sched_clock_idle_wakeup_event(0);
}
}
@@ -177,6 +179,7 @@ static ktime_t tick_nohz_start_idle(stru
}
ts->idle_entrytime = now;
ts->idle_active = 1;
+ sched_clock_idle_sleep_event();
return now;
}
next prev parent reply other threads:[~2008-09-01 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-31 15:43 [REGRESSION] High, likely incorrect process cpu usage counters with kvm and 2.6.2[67] Avi Kivity
2008-08-31 18:09 ` Parag Warudkar
2008-09-01 9:16 ` Avi Kivity
2008-09-01 14:58 ` Peter Zijlstra [this message]
2008-09-01 16:17 ` [PATCH] sched_clock: fix NOHZ interaction Avi Kivity
2008-09-05 16:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220281088.8426.63.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox