Re: [PATCH 8/9] Introduce functions to restart a process

Pavel Machek
2008-09-13T17:34:38Z

Hi!

> > @@ -233,6 +234,26 @@ ENTRY(ret_from_fork)
> > CFI_ENDPROC
> > END(ret_from_fork)
> >
> > +ENTRY(i386_ret_from_resume)
> > + CFI_STARTPROC
> > + pushl %eax
> > + CFI_ADJUST_CFA_OFFSET 4
> > + call schedule_tail
> > + GET_THREAD_INFO(%ebp)
> > + popl %eax
> > + CFI_ADJUST_CFA_OFFSET -4
> > + movl (%esp), %eax
> > + testl %eax, %eax
> > + jz 1f
> > + pushl %esp
> > + call *%eax
> > + addl $4, %esp
> > +1:
> > + addl $256, %esp

Can we do something with naming here? resume usually means 'resume
from s2ram'...

> > diff --git a/cpt/rst_process.c b/cpt/rst_process.c
> > new file mode 100644
> > index 0000000..6d47f3c
> > --- /dev/null
> > +++ b/cpt/rst_process.c
> > @@ -0,0 +1,277 @@

....and you are not even consistent. Plus, rst_ will probably be
understood as a reset by most people.

Hmmm... your syscalls get fd. What happens if I pass something like
/proc/self/maps to them?

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html