Re: [PATCH 0/9] OpenVZ kernel based checkpointing/restart

Cedric Le Goater
2008-09-03T14:26:42Z

> Forgot a global comment: you will probably get the same (rather pointless for a
> proof of concept, IMHO) requests as Oren got, to
> 1) improve coding style:
> a) especially avoid error handling like:
> err = foo();
> if (!err)
> err = bar();
> if (!err)
> err = baz();
>
> and prefer
> err = foo();
> if (err)
> goto foo_err;
> err = bar();
> ...
>
> b) do not write conditions on a single line, like
> if (foo) bar;
>
> 2) put arch-dependent code in arch/ subdirs.
> 3) I probably forgot other ones.

./scripts/checkpatch.pl catches most of it (and it does catch a few on your
patches)

but Dave is even better ! :)

Cheers,

C.

> I obviously do not personally request you to take these requests into account ;)