From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755225AbYIHSkF (ORCPT ); Mon, 8 Sep 2008 14:40:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753365AbYIHSjw (ORCPT ); Mon, 8 Sep 2008 14:39:52 -0400 Received: from accolon.hansenpartnership.com ([76.243.235.52]:46640 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753078AbYIHSjv (ORCPT ); Mon, 8 Sep 2008 14:39:51 -0400 Subject: Re: [PATCH] fix RTC_CLASS regression with PARISC From: James Bottomley To: David Brownell Cc: Linus Torvalds , Andrew Morton , linux-kernel , Parisc List In-Reply-To: <200809081119.45074.david-b@pacbell.net> References: <1220889205.8074.16.camel@localhost.localdomain> <200809081119.45074.david-b@pacbell.net> Content-Type: text/plain Date: Mon, 08 Sep 2008 13:39:49 -0500 Message-Id: <1220899189.8074.58.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2008-09-08 at 11:19 -0700, David Brownell wrote: > On Monday 08 September 2008, James Bottomley wrote: > > Put it back again by making RTC_CLASS > > unselectable if the architecture is parisc. > > Easier if those distros just wouldn't select RTC_CLASS then. :) Yes, but think of distro config people rather like users ... if you can prevent them from doing something stupid, it's a good idea. In this case, there's currently no way anyone should ever select RTC_CLASS on parisc, so we should make that clear in the Kconfig file. > And long term, better to work with RTC_CLASS. Eliminate that > crufty asm-parisc/rtc.h file and one more GEN_RTC user; and > share more widely-used infrastructure. > > If I read things right, that would be easy: the PARISC RTC is > two firmware calls, ptc_tod_{read,set}(), which would map to > RTC class {read,set}_time() methods of about six lines each. > The RTC framework can do UIE emulation, if needed. OK, I can look at that, but in the mean time could we make the option that causes the damage unselectable? This is technically a regression because before your patch GEN_RTC would override RTC_CLASS, now it's the other way around. James