From: Segher Boessenkool <segher@kernel.crashing.org>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: paulus@samba.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc: vio of_node_put cleanup
Date: Tue, 2 Jan 2007 14:55:40 +0100 [thread overview]
Message-ID: <1220f3e52f791ff8871ca9328b027a5a@kernel.crashing.org> (raw)
In-Reply-To: <200701021238.36297.m.kozlowski@tuxland.pl>
> static void __devinit vio_dev_release(struct device *dev)
> {
> - if (dev->archdata.of_node) {
> - /* XXX should free TCE table */
> - of_node_put(dev->archdata.of_node);
> - }
> + /* XXX should free TCE table */
> + of_node_put(dev->archdata.of_node);
> kfree(to_vio_dev(dev));
> }
The comment used to be inside the "if" block, is this
change correct?
[And, do we want all these changes anyway? I don't care
either way, both sides have their pros and their cons --
just asking :-) ]
Segher
next prev parent reply other threads:[~2007-01-02 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 11:38 [PATCH] ppc: vio of_node_put cleanup Mariusz Kozlowski
2007-01-02 13:55 ` Segher Boessenkool [this message]
2007-01-02 23:57 ` Mariusz Kozlowski
2007-01-03 0:24 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220f3e52f791ff8871ca9328b027a5a@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=m.kozlowski@tuxland.pl \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox