From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752722AbYIKEub (ORCPT ); Thu, 11 Sep 2008 00:50:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751355AbYIKEuS (ORCPT ); Thu, 11 Sep 2008 00:50:18 -0400 Received: from mail.windriver.com ([147.11.1.11]:37486 "EHLO mail.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbYIKEuR (ORCPT ); Thu, 11 Sep 2008 00:50:17 -0400 Subject: Re: [PATCH 1/2] fix acpi ec read write bug From: Kevin Hao To: Zhao Yakui Cc: ak@linux.intel.com, astarikovskiy@suse.de, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org In-Reply-To: <1221106057.3989.228.camel@yakui_zhao.sh.intel.com> References: <1221103065-9123-1-git-send-email-kexin.hao@windriver.com> <1221106057.3989.228.camel@yakui_zhao.sh.intel.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Thu, 11 Sep 2008 12:49:25 +0800 Message-Id: <1221108565.11106.12.camel@kevin> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) X-OriginalArrivalTime: 11 Sep 2008 04:50:05.0473 (UTC) FILETIME=[DBDBA910:01C913C9] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2008-09-11 at 12:07 +0800, Zhao Yakui wrote: > On Thu, 2008-09-11 at 11:17 +0800, Kevin Hao wrote: > > Fill in command unit of transaction_data structure, otherwise > > gpe_transaction will skip read or write instruction. > > > > Signed-off-by: Kevin Hao > > --- > > drivers/acpi/ec.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > > index bd3555c..0c65e82 100644 > > --- a/drivers/acpi/ec.c > > +++ b/drivers/acpi/ec.c > > @@ -240,6 +240,7 @@ static int acpi_ec_transaction_unlocked(struct acpi_ec *ec, u8 command, > > } > > atomic_set(&ec->irq_count, 0); > > /* fill in transaction structure */ > > + ec->t.command = command; > It is also OK to add this explicitly. In fact the ec->t.command will be > assigned in the function of acpi_ec_write_cmd. NO, I am using the latest linux-next kernel and I don't found ec->t.command is assigned in acpi_ec_write_cmd function. Thanks, Kevin > > Thanks. > > ec->t.wdata = wdata; > > ec->t.wlen = wdata_len; > > ec->t.rdata = rdata; >