Re: [PATCH] firmware: Allow release-specific firmware dir

David Woodhouse
2008-09-10T23:02:18Z

On Tue, 2008-09-09 at 10:15 -0400, Jeff Mahoney wrote:
> This patch moves them to /lib/firmware/$KERNELRELEASE. udev v127's
> firmware.sh looks there first before falling back to /lib/firmware.

NAK.

This isn't compatible with the version of udev that people actually have
installed, today. And it's also the _wrong_ thing to do.

Firmware really _isn't_ version-specific. If the firmware changes in
some incompatible way, then the filename given to request_firmware() has
to change too. Think of it like an soname on a library.

Besides, incompatible changes are fairly uncommon; firmware changes
rarely change the host<->device ABI in a way which breaks older drivers.
And that's _especially_ true for the firmwares which were present in the
kernel tree, which is all that you're moving around with this patch.

You shouldn't need more than one firmware package installed at a time --
if you are trying to do so, then that's a bug in your packaging.

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation