public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roberto De Ioris <roberto@unbit.it>
To: jeremy@xensource.com, linux-kernel@vger.kernel.org
Cc: Mirko Iannella <mirko@unbit.it>
Subject: Fix for xen guest with mem > 3.7G
Date: Sat, 13 Sep 2008 21:16:58 +0200	[thread overview]
Message-ID: <1221333418.6036.9.camel@sirius> (raw)

Xen domU kernel 2.6.26 and 2.6.27-rc cannot allocate
more than 3.7GB of ram on my PAE systems (compiled
with gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7)).

I have found the problem is in function xen_memory_setup (in
arch/x86/xen/setup.c).

It set max_pfn as 'unsigned long' but add_memory_region()
takes 'unsigned long long'.

I do not know if it is a compiler problem but this is the simple fix
(works on my systems):

--- setup.c.orig	2008-09-13 21:12:56.000000000 +0200
+++ setup.c	2008-09-13 20:35:29.000000000 +0200
@@ -36,7 +36,7 @@
 
 char * __init xen_memory_setup(void)
 {
-	unsigned long max_pfn = xen_start_info->nr_pages;
+	unsigned long long max_pfn = xen_start_info->nr_pages;
 
 	e820.nr_map = 0;
 	add_memory_region(0, LOWMEMSIZE(), E820_RAM);



-- 
Roberto De Ioris
http://unbit.it
JID: roberto@jabber.unbit.it


             reply	other threads:[~2008-09-13 19:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-13 19:16 Roberto De Ioris [this message]
2008-09-13 21:09 ` Fix for xen guest with mem > 3.7G Jeremy Fitzhardinge
2008-09-14 13:21   ` Ingo Molnar
2008-09-14 14:42     ` [PATCH] xen: " Jeremy Fitzhardinge
2008-09-14 14:47       ` Ingo Molnar
2008-09-14 21:43       ` Roberto De Ioris
2008-09-15  6:09         ` Jeremy Fitzhardinge
2008-09-15  6:20           ` Roberto De Ioris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1221333418.6036.9.camel@sirius \
    --to=roberto@unbit.it \
    --cc=jeremy@xensource.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirko@unbit.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox