Re: [PATCH 1/5] add DEFINE_LOGLEVEL_SETUP v3

Marcin Slusarz
2008-09-16T19:03:31Z

On Tue, Sep 16, 2008 at 11:01:21AM -0700, Yinghai Lu wrote:
> --- linux-2.6.orig/include/linux/kernel.h
> +++ linux-2.6/include/linux/kernel.h
> @@ -104,6 +104,15 @@ extern int console_printk[];
> #define minimum_console_loglevel (console_printk[2])
> #define default_console_loglevel (console_printk[3])
>
> +#define KERN_LOG_EMERG 0 /* system is unusable */
> +#define KERN_LOG_ALERT 1 /* action must be taken immediately */
> +#define KERN_LOG_CRIT 2 /* critical conditions */
> +#define KERN_LOG_ERR 3 /* error conditions */
> +#define KERN_LOG_WARNING 4 /* warning conditions */
> +#define KERN_LOG_NOTICE 5 /* normal but significant condition */
> +#define KERN_LOG_INFO 6 /* informational */
> +#define KERN_LOG_DEBUG 7 /* debug-level messages */
> +
> struct completion;
> struct pt_regs;
> struct user;

maybe
#define KERN_LOG_EMERG 0,KERN_EMERG
#define KERN_LOG_ALERT 1,KERN_ALERT
...
?

or better - create printk2(level, fmt) which prints "<", level, ">", fmt
and wrap it with pci_printk / acpi_printk?

Marcin