Re: [PATCH 0/6] loglevel=pci:8,acpi:8,apic=8 support v6

H. Peter Anvin
2008-09-18T15:58:46Z

Jason Baron wrote:
>
> if we take this argument to its extreme, then we end up spending all of
> our time verifying that the kernel is working correctly and no time
> actually doing work. I think 'printk_ratelimit' captures this. Thus, the line
> has to be drawn somewhere. If you want the messages in 'dmesg' use,
> printk(KERN_DEBUG), and 'grep'. For the rest, I propose pre-filtering, which is
> what 'dynamic debug' uses.
>

Taking any argument to its extreme and you come up with something
ridiculous.

One could equally argue that if you have so many debugging messages that
you have to prefilter for performance, you're so bloating your kernel
that you need to stop.

I find it highly questionable that it makes sense to put even skipped
messages into hot paths in the production kernel. Skipped prints are
NOT free, even if they are lot cheaper than actually rendering the string.

-hpa