Re: [PATCH 6/6] x86: add KERN_APIC

Ingo Molnar
2008-09-17T08:52:50Z

* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> On Wed, Sep 17, 2008 at 1:38 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> >
> >> and kill apic_printk
> >> using loglevel=apic:8 instead
> >
> > yes, that aspect is very nice.
> >
> >> +DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 6);
> >
> >> - printk(KERN_WARNING "APIC calibration not consistent "
> >> + printk(KERN_WARNING KERN_APIC "APIC calibration not consistent "
> >
> > here too the question arises: what should the semantics of the 'mixing'
> > of such subsystem printk tags with the classic priority tags be. I think
> > in this particular case we dont want the KERN_APIC tag, as that would
> > prevent this failure message to be printed by default. I.e. this line
> > should remain:
> >
> >> - printk(KERN_WARNING "APIC calibration not consistent "
> >
> > to make sure this warning always shows up in the logs. Agreed?
>
> with
>
> DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 6);
>
> the KERN_WARNING <5> will be showing up that warning, even without
> loglevl=apic:8

ok, but if that printk will show up no matter what, why is there any
need to add an extra tag?

my main worry is the duplication of the tag. People have a hard enough
time adding a _single_ printk tag - adding multiple ones is clearly too
much.

Ingo