Re: [PATCH 6/6] x86: add KERN_APIC

Ingo Molnar
2008-09-17T08:38:40Z

* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> and kill apic_printk
> using loglevel=apic:8 instead

yes, that aspect is very nice.

> +DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 6);

> - printk(KERN_WARNING "APIC calibration not consistent "
> + printk(KERN_WARNING KERN_APIC "APIC calibration not consistent "

here too the question arises: what should the semantics of the 'mixing'
of such subsystem printk tags with the classic priority tags be. I think
in this particular case we dont want the KERN_APIC tag, as that would
prevent this failure message to be printed by default. I.e. this line
should remain:

> - printk(KERN_WARNING "APIC calibration not consistent "

to make sure this warning always shows up in the logs. Agreed?

Ingo