Re: [PATCH 3/6] pci: using printk(KERN_PCI v3

Ingo Molnar
2008-09-17T08:35:47Z

* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> - printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
> + printk(KERN_DEBUG KERN_PCI
> + "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",

i think we should aim to make the common usage of this facility as easy
and short as possible. That means that i think the right line is:

+ printk(KERN_PCI
+ "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",

as that is the shortest form. KERN_PCI should imply whatever
common-sense default. It should still make sense to specify KERN_FOO
KERN_PCI, to override that default.

Ingo