From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754411AbYIZBXs (ORCPT ); Thu, 25 Sep 2008 21:23:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752705AbYIZBXh (ORCPT ); Thu, 25 Sep 2008 21:23:37 -0400 Received: from mail.windriver.com ([147.11.1.11]:36819 "EHLO mail.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbYIZBXg (ORCPT ); Thu, 25 Sep 2008 21:23:36 -0400 Subject: Re: [PATCH] net: remove LLTX in atl2 driver From: Kevin Hao To: Jay Cliburn Cc: Chris Snook , Jeff Garzik , Jeff Garzik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20080925185849.0df482e2@osprey.hogchain.net> References: <1222302922-13200-1-git-send-email-kexin.hao@windriver.com> <48DBF4DD.8060908@redhat.com> <48DBFAB5.2010709@garzik.org> <48DC11F5.20900@redhat.com> <20080925185849.0df482e2@osprey.hogchain.net> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Fri, 26 Sep 2008 09:20:42 +0800 Message-Id: <1222392042.2682.40.camel@kevin> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) X-OriginalArrivalTime: 26 Sep 2008 01:21:39.0866 (UTC) FILETIME=[3A21B7A0:01C91F76] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2008-09-25 at 18:58 -0500, Jay Cliburn wrote: > On Thu, 25 Sep 2008 18:34:29 -0400 > Chris Snook wrote: > > > > > I'm all in favor of removing legacy cruft. I want to know a little > > more about it so we can remove it from the atl1 code as well. > > Ultimately most of this will be shared code. > > Yes, LLTX can (and should) be removed from the atl1 code. I had an > exchange with Herbert Xu and David Miller on LKML a few weeks ago, and > they gave me a few tips on how to do it, but I haven't yet had the > time. What takes an experienced netdev warrior about a half hour to > implement unfortunately takes me days of after-dayjob time as I track > through all the calls that that are affected and test the modified > driver. > > Now back to atl2... I'd like to hear from Kevin also whether he tested > the LLTX removal. I'm building the driver with his patch as we speak, > and I'll test it myself this weekend, but Kevin I'd still like to know > if you tested the patch. Yes, I have tested this driver on a Eee PC. It works well. Thanks, Kevin > > Thanks, > Jay