From: Adam Jackson <ajax@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Jones <pjones@redhat.com>, Adam Jackson <ajax@redhat.com>
Subject: [PATCH] Don't print an error message just because there's no i8042 chip
Date: Mon, 29 Sep 2008 14:36:44 -0400 [thread overview]
Message-ID: <1222713404-1097-1-git-send-email-ajax@redhat.com> (raw)
From: Peter Jones <pjones@redhat.com>
Some systems, such as EFI-based Apple systems, won't necessarily have an
i8042 to initialize. We shouldn't be printing an error message in this
case, since not detecting the chip is the correct behavior.
Signed-off-by: Adam Jackson <ajax@redhat.com>
---
drivers/input/serio/i8042.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 170f71e..4f3e632 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -701,10 +701,8 @@ static int __devinit i8042_check_aux(void)
static int i8042_controller_check(void)
{
- if (i8042_flush() == I8042_BUFFER_SIZE) {
- printk(KERN_ERR "i8042.c: No controller found.\n");
+ if (i8042_flush() == I8042_BUFFER_SIZE)
return -ENODEV;
- }
return 0;
}
--
1.6.0.1
next reply other threads:[~2008-09-29 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 18:36 Adam Jackson [this message]
2014-02-25 15:47 ` [PATCH] i8042: Don't print an error message just because there's no chip Adam Jackson
2014-02-25 16:06 ` Josh Boyer
2014-06-03 13:53 ` Adam Jackson
2014-06-03 14:00 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222713404-1097-1-git-send-email-ajax@redhat.com \
--to=ajax@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox