Re: [PATCH] slub: reduce total stack usage of slab_err & object_err

Jörn Engel
2008-10-01T10:32:53Z

On Wed, 1 October 2008 11:06:07 +0100, Richard Kennedy wrote:
>
> No I haven't made it available as it's really only a proof of concept,
> and I still don't have any sensible ideas how to deal with pointers to
> functions. Plus I'm still testing it to see if the results are anything
> like reasonable.
> Also it's finding lots of potentially recursive code paths and my
> heuristic to deal with them is very basic. I'm just adding a feature so
> that I can ignore some code paths, so maybe that will help.

Sounds very familiar. ;)

Function pointers are fairly easy. When a function pointer is part of a
structure, simply consider that pointer to be a pseudo-function that
doesn't consume any stack space. Whenever that pointer is written to,
that value can be "called" from the pseudo-function. Callback functions
that are passed as function parameters can be handles similarly.

Getting this information wasn't too hard with smatch, but smatch depends
on gcc 3.1, which has *ahem* matured a bit.

Recursions essentially consume an infinite amount of stack unless you
know the upper bound for them. I handled this two-fold. First, every
single recursion is reported. Secondly, every recursion is assumed to
be taken exactly once when calculating stack consumption. This is the
minimal sane value. Feel free to pick two or three if you prefer.

The main function code was done in two stages, iirc. First stage simply
creates the call graph in memory. Somewhere in the range of a million
objects. Then I collapsed the graph from the leaves. If function A
calls functions B, C and D, you first throw away two of the called
functions and keep the one with the biggest stack footprint. Then A is
turned into a function A' that has the combined stack footprint of A and
B (assuming C and D are lighter) and is a leaf function. Add some
annotation that B is called, along with anything B itself called before
it was collapsed.

If you use this method, recursions will sooner or later turn into a
pattern where A calls A. Trivial to detect.

Maybe my thesis has a few more details:
http://wh.fh-wedel.de/~joern/quality.pdf

Jörn

--
Joern's library part 13: