Re: [PATCH] slub: reduce total stack usage of slab_err & object_err

Christoph Lameter
2008-09-30T17:37:16Z

Richard Kennedy wrote:

> Yes, using vprintk is better but you still have this path :
> ( with your patch applied)
>
> object_err -> slab_bug(208) -> printk(216)
> instead of
> object_err -> slab_bug_message(8) -> printk(216)
>
> unfortunately the overhead for having var_args is pretty big, at least
> on x86_64. I haven't measured it on 32 bit yet.

Really 208 bytes for a va arg parameter declaration? I expected it to be
simply a null terminated pointer list.