Re: [patch] clean hex output of ftrace

[Harvey Harrison <harvey.harrison@gmail.com>]

On Thu, 2008-10-09 at 14:31 +0200, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@gmail.com> wrote:
> 
> > On Wed, 2008-10-08 at 17:16 -0700, Joe Perches wrote:
> > > On Wed, 8 Oct 2008, Harvey Harrison wrote:
> > > > From: Harvey Harrison <harvey.harrison@gmail.com>
> > > > Subject: [PATCH] ftrace: Fix inversion of hex output and use common routines
> > > 
> > > You're quick...
> > > 
> > > >  	BUG_ON(len >= HEX_CHARS);
> > > 
> > > I think the BUG_ON is senseless.
> > > 
> > 
> > Agreed, it probably meant to say BUG_ON(len * 2 > HEX_CHARS -1)
> > 
> > But as this is only called from within a helper macro, it could be
> > changed to a build-time check instead of a runtime:
> > 
> > From: Harvey Harrison <harvey.harrison@gmail.com>
> > Subject: [PATCH] trace: add build-time check to avoid overrunning hex buffer
> 
> applied to tip/tracing/core:
> 
>  bb86ba7: trace: add build-time check to avoid overrunning hex buffer
>  32ce86f: ftrace: fix hex output mode of ftrace
> 

Thinking about this, these should probably be forwarded to -stable once
they go into mainline.

Cheers,

Harvey