public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Pellegrin <chripell@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH] max3100 driver
Date: Fri, 10 Oct 2008 14:08:58 +0200	[thread overview]
Message-ID: <12236405383272-git-send-email-chripell@gmail.com> (raw)
In-Reply-To: <20080920012454.e40f03cc.akpm@linux-foundation.org>


Hi,

This patch fixes a problem about PM in my code that I found when testing
patches that went in -mm. The full patch against the Linus tree can be
found at http://www.evolware.org/chri/paciugo/

---
diff --git a/drivers/serial/max3100.c b/drivers/serial/max3100.c
index 7a269a6..462d6a4 100644
--- a/drivers/serial/max3100.c
+++ b/drivers/serial/max3100.c
@@ -566,6 +566,7 @@ static void max3100_shutdown(struct uart_port *port)
 	if (s->workqueue) {
 		flush_workqueue(s->workqueue);
 		destroy_workqueue(s->workqueue);
+		s->workqueue = NULL;
 	}
 	if (s->irq)
 		free_irq(s->irq, s);
@@ -614,6 +615,7 @@ static int max3100_startup(struct uart_port *port)
 		dev_warn(&s->spi->dev, "cannot allocate irq %d\n", s->irq);
 		s->irq = 0;
 		destroy_workqueue(s->workqueue);
+		s->workqueue = NULL;
 		return -EBUSY;
 	}
 
@@ -884,7 +886,8 @@ static int max3100_resume(struct spi_device *spi)
 	enable_irq(s->irq);
 
 	s->conf_commit = 1;
-	max3100_dowork(s);
+	if (s->workqueue)
+		max3100_dowork(s);
 
 	return 0;
 }

  parent reply	other threads:[~2008-10-10 12:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-20  7:20 [PATCH] max3100 driver Christian Pellegrin
2008-09-20  8:24 ` Andrew Morton
2008-09-20 10:35   ` chri
2008-09-20 13:56   ` Arjan van de Ven
2008-09-20 14:30     ` chri
2008-09-20 14:34     ` Alan Cox
2008-09-21 16:09     ` Ben Pfaff
2008-10-09  6:23   ` chri
2008-10-10 12:08   ` Christian Pellegrin [this message]
2008-09-20 14:11 ` Alan Cox
2008-09-20 14:37   ` chri
2008-10-09  6:30   ` chri
2008-10-09  9:18     ` Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2008-09-20 10:51 Michael Trimarchi
2007-12-17  8:17 chripell
2007-12-17  8:45 ` Jiri Slaby
2007-12-17  8:55   ` chri
2007-12-17  9:00     ` Jiri Slaby
2007-12-05 10:26 chripell
2007-12-12  9:49 ` Andrew Morton
2007-12-12 11:58   ` chri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12236405383272-git-send-email-chripell@gmail.com \
    --to=chripell@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox