From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dougthompson@xmission.com, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH 1/1] edac cell: fix incorrect edac_mode
Date: Fri, 17 Oct 2008 10:49:02 +1100 [thread overview]
Message-ID: <1224200942.7654.29.camel@pasglop> (raw)
In-Reply-To: <20081016163532.273ea02f.akpm@linux-foundation.org>
On Thu, 2008-10-16 at 16:35 -0700, Andrew Morton wrote:
> Well that sounds a bit wrong of it.
>
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Signed-off-by: Doug Thompson <dougthompson@xmission.com>
> > ---
> >
> > drivers/edac/cell_edac.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-work.orig/drivers/edac/cell_edac.c 2008-10-15
> 15:35:21.000000000 +1100
> > +++ linux-work/drivers/edac/cell_edac.c 2008-10-15
> 15:35:29.000000000 +1100
> > @@ -142,7 +142,7 @@ static void __devinit cell_edac_init_csr
> > csrow->nr_pages = (r.end - r.start + 1) >> PAGE_SHIFT;
> > csrow->last_page = csrow->first_page + csrow->nr_pages
> - 1;
> > csrow->mtype = MEM_XDR;
> > - csrow->edac_mode = EDAC_FLAG_EC | EDAC_FLAG_SECDED;
> > + csrow->edac_mode = EDAC_SECDED;
> > dev_dbg(mci->dev,
> > "Initialized on node %d, chanmask=0x%x,"
> > " first_page=0x%lx, nr_pages=0x%x\n",
>
> Seems to be needed in 2.6.27.x? Applies OK to 2.6.26, 2.6.25, etc.
>
> How far back shold we port this?
.25 sounds fine.
Cheers,
Ben.
prev parent reply other threads:[~2008-10-16 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 18:13 [PATCH 1/1] edac cell: fix incorrect edac_mode dougthompson
2008-10-16 23:35 ` Andrew Morton
2008-10-16 23:49 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224200942.7654.29.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox