linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Kumar Gala <galak@kernel.crashing.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Becky Bruce <becky.bruce@freescale.com>
Subject: Re: [git pull] core kernel updates for v2.6.28
Date: Fri, 17 Oct 2008 11:41:31 +1100	[thread overview]
Message-ID: <1224204091.7654.45.camel@pasglop> (raw)
In-Reply-To: <1224204023.7654.43.camel@pasglop>

On Fri, 2008-10-17 at 11:40 +1100, Benjamin Herrenschmidt wrote:
> Ok, so I didn't spot a problem with your hand-merge of the phys_addr_t
> stuff, but that was a quick look, I'll let Becky test the FSL
> platforms . However, one of my test configs broke with:

Argh.. sent too fast :-) So I said, it broke with:

/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:819: warning: ‘enum nf_nat_manip_type’ declared inside parameter list
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:819: warning: its scope is only this definition or declaration, which is probably not what you want
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:818: error: parameter 2 (‘manip’) has incomplete type
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c: In function ‘ctnetlink_parse_nat_setup’:
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:821: error: ‘nfnetlink_parse_nat_setup_hook’ undeclared (first use in this function)
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:821: error: (Each undeclared identifier is reported only once
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:821: error: for each function it appears in.)
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:821: warning: type defaults to ‘int’ in declaration of ‘parse_nat_setup’
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:823: warning: type defaults to ‘int’ in declaration of ‘_________p1’
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:823: warning: type defaults to ‘int’ in declaration of ‘type name’
/home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:841: error: called object ‘parse_nat_setup’ is not a function

Cheers,
Ben.



  reply	other threads:[~2008-10-17  0:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 12:50 [git pull] core kernel updates for v2.6.28 Ingo Molnar
2008-10-16 22:32 ` Linus Torvalds
2008-10-16 22:43   ` Frédéric Weisbecker
2008-10-16 22:57     ` Linus Torvalds
2008-10-16 23:16       ` Frédéric Weisbecker
2008-10-16 23:05   ` Benjamin Herrenschmidt
2008-10-17  0:40   ` Benjamin Herrenschmidt
2008-10-17  0:41     ` Benjamin Herrenschmidt [this message]
2008-10-17  6:23   ` [git pull] core kernel fixes Ingo Molnar
2008-10-18  2:58   ` [git pull] core kernel updates for v2.6.28 Becky Bruce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224204091.7654.45.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=becky.bruce@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).