Re: [PATCH] Fix broken debug output reserve_region_with_split()

Benjamin Herrenschmidt
2008-10-17T03:32:28Z

On Thu, 2008-10-16 at 20:13 -0700, Roland Dreier wrote:
> > + * Right now we handle:
> > + *
> > + * - 'F' For symbolic Function descriptor pointers
> > + * - 'S' For Symbolic direct pointers), but this can easily be
> > + * extended in the future (network address types etc).
> > + * - 'R' For a struct resouce pointer, it prints the range of
> > + * addresses (not the name nor the flags)
>
> A little too much cut and paste -- the "easily be extended" bit at 'S'
> doesn't really make sense in the middle of the list.

Right :-)

> > + * Note: The difference between 'S' and 'F' is that on ia64 and ppc64
> > + * function pointers are really function descriptors, which contain a
> > + * pointer the real address.
>
> you cut and pasted Linus's typo too -- "a pointer the real address"
> should probably be "a pointer *TO* the real address"

Ok, I'll wait for more comments before a respin to :-) I'm mostly
wondering whether to use fixed sized format rather than the current
variable size (and pad with zeros).

Cheers,
Ben.