Re: [PATCH] Fix broken debug output reserve_region_with_split()

Yinghai Lu
2008-10-14T01:14:33Z

On Mon, Oct 13, 2008 at 6:04 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> Benjamin Herrenschmidt wrote:
>>
>> That debug outpout in kernel/resource.c is busted on 32-bit
>> machines, fix it with appropriate casts.
>>
>> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> ---
>>
>> One day Yinghai will figure out that resource_size_t can be 32-bit
>> and thus as printk arguments must be cast to (unsigned long long)
>> explicitely when using %llx... hopefully, that day, Ingo will also
>> catch these before committing them as it's not the first one like
>> this :-)

we had patch to remove that two debug lines.

>>
>
> I really think Linus' solution (add a resource printf modifier, that can
> contain the whole format) is much better.

yes. some pci resource print out etc could use that too.
to get rid of the annoying casting.

BTW: can you just enforce resource_t to u64?

YH