public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Geert.Uytterhoeven@sonycom.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org, mingo@elte.hu,
	David Miller <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()
Date: Fri, 17 Oct 2008 14:46:32 +1100	[thread overview]
Message-ID: <1224215192.7654.70.camel@pasglop> (raw)
In-Reply-To: <86802c440810162039v7c347888i34e26058b70f37d5@mail.gmail.com>


> >
> > +static char *resource_string(char *buf, char *end, struct resource *res, int field_width, int precision, int flags)
> > +{
> > +       /* room for the actual numbers, the two "0x", -, [, ] and the final zero */
> > +       char sym[4*sizeof(resource_size_t) + 8];
> > +       char *p = sym, *pend = sym + sizeof(sym);
> > +
> > +       *p++ = '[';
> > +       p = number(p, pend, res->start, 16, -1, -1, SPECIAL | SMALL);
> > +       *p++ = '-';
> > +       p = number(p, pend, res->end, 16, -1, -1, SPECIAL | SMALL);
> > +       *p++ = ']';
> > +       *p = 0;
> > +
> > +       return string(buf, end, sym, field_width, precision, flags);
> 
> so x64 64bit,io ports will be print out 8 digital?

With that patch, it will use just as many digits as necessary to display
a given number. The question I'm asking in the comments is whether we
want to instead use fixed digits with zero padding, and in that case,
do we want a hook or something for archs to decide how many digits
for IO vs. memory.

But at least with that in, we can start converting callers. I have a
patch converting PCI that I'll post once that goes in and I'll start
scrubbing arch/powerpc soon.

Cheers,
Ben.


  reply	other threads:[~2008-10-17  3:47 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14  0:53 [PATCH] Fix broken debug output reserve_region_with_split() Benjamin Herrenschmidt
2008-10-14  1:04 ` H. Peter Anvin
2008-10-14  1:14   ` Yinghai Lu
2008-10-14  1:16     ` H. Peter Anvin
2008-10-14  1:34     ` David Miller
2008-10-14  1:41     ` Benjamin Herrenschmidt
2008-10-14  1:41   ` Benjamin Herrenschmidt
2008-10-14  1:45     ` David Miller
2008-10-14  2:15       ` Benjamin Herrenschmidt
2008-10-14  2:54     ` H. Peter Anvin
2008-10-14  3:47       ` Benjamin Herrenschmidt
2008-10-14  5:38       ` David Miller
2008-10-16  8:30         ` Geert Uytterhoeven
2008-10-16  8:38           ` David Miller
2008-10-16  9:02             ` H. Peter Anvin
2008-10-17  3:02             ` Benjamin Herrenschmidt
2008-10-17  3:06               ` Benjamin Herrenschmidt
2008-10-17  3:13                 ` Roland Dreier
2008-10-17  3:31                   ` Benjamin Herrenschmidt
2008-10-17  3:49                     ` Linus Torvalds
2008-10-17  4:04                       ` David Miller
2008-10-17  4:18                         ` Linus Torvalds
2008-10-17  5:00                           ` Benjamin Herrenschmidt
2008-10-17  5:24                             ` David Miller
2008-10-17  5:12                           ` Benjamin Herrenschmidt
2008-10-17  5:21                             ` Benjamin Herrenschmidt
2008-10-17 10:13                             ` Olivier Galibert
2008-10-17 15:54                             ` Linus Torvalds
2008-10-17 20:30                               ` H. Peter Anvin
2008-10-17 20:54                                 ` Linus Torvalds
2008-10-17 21:03                               ` Benjamin Herrenschmidt
2008-10-17 21:11                                 ` Linus Torvalds
2008-10-17 21:45                                   ` Benjamin Herrenschmidt
2008-10-20  3:37                                     ` Benjamin Herrenschmidt
2008-10-17  5:21                           ` David Miller
2008-10-17  6:36                             ` Benjamin Herrenschmidt
2008-10-17  6:39                               ` H. Peter Anvin
2008-10-17  6:47                                 ` David Miller
2008-10-17  6:51                                   ` H. Peter Anvin
2008-10-17 15:51                             ` Linus Torvalds
2008-10-17 20:06                               ` David Miller
2008-10-17  4:05                       ` Benjamin Herrenschmidt
2008-10-17  6:36                         ` H. Peter Anvin
2008-10-17  3:39                 ` Yinghai Lu
2008-10-17  3:46                   ` Benjamin Herrenschmidt [this message]
2008-10-17  6:38                     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224215192.7654.70.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox