From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Joel Becker <joel.becker@oracle.com>, Greg KH <greg@kroah.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
"Linux-iSCSI.org Target Dev"
<linux-iscsi-target-dev@googlegroups.com>,
SCST-Devel <scst-devel@lists.sourceforge.net>,
Alan Stern <stern@rowland.harvard.edu>,
Andrew Morton <akpm@osdl.org>,
Christoph Hellwig <hch@infradead.org>
Subject: [PATCH] [ConfigFS]: Allow symbolic links from a SysFS struct kobject source.
Date: Thu, 16 Oct 2008 23:55:55 -0700 [thread overview]
Message-ID: <1224226555.5556.279.camel@haakon2.linux-iscsi.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]
Hi Joel, Greg and Co,
Here is the the first working code for allowing configfs to handle
symlinks from sysfs struct kobject based code. Here is the commit:
passing struct kobject into generic target_core_mod subsystem plugins
for locating struct block_device and struct scsi_device..
-------------------------------------------------------------------------
In struct configfs_item_operations, added allow_link_kobject() and
drop_link_kobject() to allow struct kobject to be passed through
the configfs API. The code for kobject symlink source sits along side
the exist configfs symlink code, and does not break existing apps that use
allow_link() or drop_link().
Also, there is two large FIXMEs with the first commit, in
fs/configfs/symlink.c:configfs_symlink() related to comparing
struct nameidata nd.path.dentry->d_sb == sysfs_sb.
The 2nd is when doing a 'ls -la' inside of the config group directory
containg the symlink source from sysfs, the source link does not currently
appear.. I will be following up these two items..
Signed-off-by: Nicholas A. Bellinger
---
fs/configfs/configfs_internal.h | 3 +-
fs/configfs/symlink.c | 168 +++++++++++++++++++++++++++------------
include/linux/configfs.h | 6 +-
3 files changed, 123 insertions(+), 54 deletions(-)
the following commit can be found at:
http://git.kernel.org/?p=linux/kernel/git/nab/lio-core-2.6.git;a=commit;h=317aefe74354c0140dc8aebff1ef9467b6f0c9ba
Comments..? I will send along my patch to
drivers/lio-core/target_core_configfs.c in a moment to demonstrate how
to pull it all together with struct config_item_operations
allow_link_kobject() and drop_link_kobject()..
[-- Attachment #2: 0001-ConfigFS-Allow-symbolic-links-from-a-SysFS-struct.patch --]
[-- Type: application/mbox, Size: 9616 bytes --]
next reply other threads:[~2008-10-17 6:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 6:55 Nicholas A. Bellinger [this message]
2008-10-17 7:44 ` [PATCH] [ConfigFS]: Allow symbolic links from a SysFS struct kobject source Greg KH
2008-10-17 8:22 ` Nicholas A. Bellinger
2008-10-17 11:32 ` Matthew Wilcox
2008-10-17 19:02 ` Nicholas A. Bellinger
2008-10-17 17:39 ` Greg KH
2008-10-17 19:19 ` Nicholas A. Bellinger
2008-10-17 20:10 ` Greg KH
2008-10-18 2:41 ` Nicholas A. Bellinger
2008-10-17 19:48 ` Joel Becker
2008-10-17 20:03 ` Nicholas A. Bellinger
2008-10-17 20:07 ` Nicholas A. Bellinger
2008-10-17 19:39 ` Joel Becker
2008-10-17 19:50 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224226555.5556.279.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=joel.becker@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-iscsi-target-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=scst-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox