Re: [PATCH 5/9] Restore memory address space

Dave Hansen
2008-10-17T15:39:51Z

On Fri, 2008-10-17 at 10:44 +0200, Nadia Derbey wrote:
> On Thu, 2008-10-16 at 11:14 -0700, Dave Hansen wrote:
> > +static int cr_page_read(struct cr_ctx *ctx, struct page *page, char *buf)
> > +{
> > + void *ptr;
> > + int ret;
> > +
> > + ret = cr_kread(ctx, buf, PAGE_SIZE);
> > + if (ret < 0)
> > + return ret;
> > +
> > + ptr = kmap_atomic(page, KM_USER1);
> > + memcpy(ptr, buf, PAGE_SIZE);
> > + kunmap_atomic(page, KM_USER1);
>
> Here too, I think this should be changed to
> kunmap_atomic(ptr, KM_USER1);

Thanks, Nadia.

These fixes will show up in the git tree shortly:

http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/daveh/linux-2.6-cr.git;a=summary

I just created it, so it may take a few moments for the gitweb script to
find it.

-- Dave