Re: [PATCH] Fix broken debug output reserve_region_with_split()

H. Peter Anvin
2008-10-16T09:06:17Z

David Miller wrote:
> From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> Date: Thu, 16 Oct 2008 10:30:52 +0200 (CEST)
>
>> On Mon, 13 Oct 2008, David Miller wrote:
>>> From: "H. Peter Anvin" <hpa@zytor.com>
>>> Date: Mon, 13 Oct 2008 19:54:33 -0700
>>>
>>>> I pointed out that we should use the flags to determine formatting
>>>> options, e.g. I/O space is only 16 bits on x86.
>>> It's 64-bit on sparc64 :-)
>>>
>>> There's also the bit where we use a 32-bit resource_t on sparc32
>>> but encode the top 4-bits of the 36 bit physical I/O address in
>>> the resource flags member.
>> So wouldn't it be better to switch those sparc32 configs to a 64-bit
>> resource_t? I think all other platforms with 36-bit physical addresses went
>> that way.
>
> Absolutely, this is what should happen.
>
> I'll try to make this happen in 2.6.29, it's a moderately invasive
> change because it effects how ioremap() and friends are implemented.

Either way, it totally underscores how desirable it is to centralize
this particular class of formatting.

-hpa