Re: [PATCH] Fix broken debug output reserve_region_with_split()

Benjamin Herrenschmidt
2008-10-17T04:06:40Z

On Thu, 2008-10-16 at 20:49 -0700, Linus Torvalds wrote:
>
> On Fri, 17 Oct 2008, Benjamin Herrenschmidt wrote:
> >
> > Ok, I'll wait for more comments before a respin to :-) I'm mostly
> > wondering whether to use fixed sized format rather than the current
> > variable size (and pad with zeros).
>
> Sadly, I think that gcc warns if we were to support %08pR, so we can't
> pass down flags.
>
> That said, I don't much like SPECIAL in the flags. We never do that thing.
> Doing a git grep for some range printouts, we tend to do things like

I hesitated, but DaveM convinced me if you get a range of IO ports such
as 138-139, do you know on a first look that it's hex ? :-)

> and the 04 would be parsed as flags, the same way we do %04x. And then if
> you want the 0x, you can use %p#08R..

Shouldn't we be consistent and have resources always be printed using
the same format ?

Cheers,
Ben.