Re: [PATCH] Fix broken debug output reserve_region_with_split()

H. Peter Anvin
2008-10-17T06:41:52Z

Benjamin Herrenschmidt wrote:
>
> With that patch, it will use just as many digits as necessary to display
> a given number. The question I'm asking in the comments is whether we
> want to instead use fixed digits with zero padding, and in that case,
> do we want a hook or something for archs to decide how many digits
> for IO vs. memory.
>

Yes, and yes.

We want to pad to keep people from mistaking, say, c000000 from
c0000000. At least on x86, it also acts as a visual cue for the type of
resource space, as people are used to seeing I/O ports as 16-bit numbers
with four hexdigits, and 8- or 16-hexdigit numbers for memory addresses.

-hpa