Re: [PATCH] Fix broken debug output reserve_region_with_split()

H. Peter Anvin
2008-10-14T02:58:01Z

Benjamin Herrenschmidt wrote:
>>>
>> I really think Linus' solution (add a resource printf modifier, that can
>> contain the whole format) is much better.
>
> I agree. In fact I may even have a patch somewhere for that.
>
> It has to be a pointer tho, thus what do we want ? Something that takes
> a pointer to a resource_size_t or to a whole struct resource ? In the
> later case, do we want to print the whole flags too ?
>

Linus already posted a patch. He took a struct resource
and printed it as a range. I pointed out that we should use the flags
to determine formatting options, e.g. I/O space is only 16 bits on x86.

-hpa