From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
linux-pci@vger.kernel.org, yhlu.kernel@gmail.com,
Andrew Morton <akpm@linux-foundation.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] x86, ioremap: use %pR in printk
Date: Mon, 20 Oct 2008 19:34:42 +1100 [thread overview]
Message-ID: <1224491682.7654.135.camel@pasglop> (raw)
In-Reply-To: <20081020071203.GB12131@elte.hu>
On Mon, 2008-10-20 at 09:12 +0200, Ingo Molnar wrote:
> * Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > This converts things in drivers/pci to use %pR to printout the
> > content of a struct resource instead of hand-casted %llx or
> > other variants.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> cool!
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
>
> there's also two places in arch/x86/mm/ioremap.c that could use this
> straight away - see the (untested) patch below.
No, you don't pass it a phys_addr_t or a resource_size_t, you pass it a
struct resource *
Now, I would have liked to have a way to print a resource_size_t (or
phys_addr_t) but that's harder because we need pointers for the magic
typechecking to work (among others).
Maybe we could create a special format for a pointer-to-resource_size_t
and pass &foo on callers but that's fishy...
Cheers,
Ben.
next prev parent reply other threads:[~2008-10-20 8:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 4:07 [PATCH 2/2] pci: Use new %pR to print resource ranges Benjamin Herrenschmidt
2008-10-20 7:12 ` [PATCH] x86, ioremap: use %pR in printk Ingo Molnar
2008-10-20 8:34 ` Benjamin Herrenschmidt [this message]
2008-10-20 9:05 ` Ingo Molnar
2008-10-20 11:00 ` Ingo Molnar
2008-10-20 11:15 ` Benjamin Herrenschmidt
2008-10-20 11:22 ` Benjamin Herrenschmidt
2008-10-20 11:31 ` Ingo Molnar
2008-10-20 11:36 ` Ingo Molnar
2008-10-20 12:58 ` Johannes Berg
2008-10-20 13:15 ` Ingo Molnar
2008-10-20 21:35 ` Benjamin Herrenschmidt
2008-10-21 6:47 ` Johannes Berg
2008-10-20 13:04 ` Matthew Wilcox
2008-10-20 21:33 ` Benjamin Herrenschmidt
2008-10-20 21:34 ` Benjamin Herrenschmidt
2008-10-20 11:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224491682.7654.135.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox