Re: [PATCH] x86, ioremap: use %pR in printk

Benjamin Herrenschmidt
2008-10-20T08:35:47Z

On Mon, 2008-10-20 at 09:12 +0200, Ingo Molnar wrote:
> * Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > This converts things in drivers/pci to use %pR to printout the
> > content of a struct resource instead of hand-casted %llx or
> > other variants.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> cool!
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
>
> there's also two places in arch/x86/mm/ioremap.c that could use this
> straight away - see the (untested) patch below.

No, you don't pass it a phys_addr_t or a resource_size_t, you pass it a
struct resource *

Now, I would have liked to have a way to print a resource_size_t (or
phys_addr_t) but that's harder because we need pointers for the magic
typechecking to work (among others).

Maybe we could create a special format for a pointer-to-resource_size_t
and pass &foo on callers but that's fishy...

Cheers,
Ben.