Re: [PATCH] x86, ioremap: use %pR in printk

Benjamin Herrenschmidt
2008-10-20T21:34:18Z

On Mon, 2008-10-20 at 13:36 +0200, Ingo Molnar wrote:
> got rid of the brackets, see the patches below.
>
> One open question would be whether to set the width to 8 on 32-bit
> platforms and 16 on 64-bit platforms - right now it's 8 on both. Since
> this is specifically a 'physical address' thing it might make sense to
> extend that on 64-bit systems. (although it's quite a bit of screen real
> estate so i think the current width of 8 should be fine)

A -lot- of 64-bit platforms (though not all of them) have most of their
stuff still in the 32 bit space, especially when IO is concerned.
Keeping it to 8 thus makes the output nicer on those, and as Linus
mentioned before, it's not like we lose digits anyway.

If you want, you can re-use the #ifdef/#define I did for resources and
thus give archs the option to have a different default.

Cheers,
Ben.