* [PATCH] sound: correct bracketing in spdif test
@ 2008-10-22 3:28 Harvey Harrison
2008-10-22 3:38 ` Matthew Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: Harvey Harrison @ 2008-10-22 3:28 UTC (permalink / raw)
To: Matthew Ranostay, Takashi Iwai; +Cc: LKML
Noticed by sparse:
sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
sound/pci/hda/patch_sigmatel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index a2ac720..788fdc6 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
return err;
spec->multiout.share_spdif = 1;
}
- if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
+ if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
if (err < 0)
return err;
--
1.6.0.2.824.geb4d2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] sound: correct bracketing in spdif test
2008-10-22 3:28 [PATCH] sound: correct bracketing in spdif test Harvey Harrison
@ 2008-10-22 3:38 ` Matthew Ranostay
2008-10-22 6:02 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Ranostay @ 2008-10-22 3:38 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Takashi Iwai, LKML
Harvey Harrison wrote:
> Noticed by sparse:
> sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> sound/pci/hda/patch_sigmatel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index a2ac720..788fdc6 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
> return err;
> spec->multiout.share_spdif = 1;
> }
> - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
> + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
> err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
> if (err < 0)
> return err;
Thanks for finding this.
Acked-by: Matthew Ranostay <mranostay@embeddedalley.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sound: correct bracketing in spdif test
2008-10-22 3:38 ` Matthew Ranostay
@ 2008-10-22 6:02 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2008-10-22 6:02 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Matthew Ranostay, LKML
At Tue, 21 Oct 2008 23:38:31 -0400,
Matthew Ranostay wrote:
>
> Harvey Harrison wrote:
> > Noticed by sparse:
> > sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > sound/pci/hda/patch_sigmatel.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> > index a2ac720..788fdc6 100644
> > --- a/sound/pci/hda/patch_sigmatel.c
> > +++ b/sound/pci/hda/patch_sigmatel.c
> > @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
> > return err;
> > spec->multiout.share_spdif = 1;
> > }
> > - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
> > + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
> > err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
> > if (err < 0)
> > return err;
>
> Thanks for finding this.
>
>
> Acked-by: Matthew Ranostay <mranostay@embeddedalley.com>
Applied now. Thanks!
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-22 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-22 3:28 [PATCH] sound: correct bracketing in spdif test Harvey Harrison
2008-10-22 3:38 ` Matthew Ranostay
2008-10-22 6:02 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox