public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mmc: trivial annotation of 'blocks'
@ 2008-10-23  0:09 Harvey Harrison
  2008-10-26 11:50 ` Pierre Ossman
  0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-10-23  0:09 UTC (permalink / raw)
  To: Pierre Ossman; +Cc: Andrew Morton, LKML

sg_init_one is reading a be32, annotate as such.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 drivers/mmc/card/block.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 3d067c3..903c8aa 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -145,7 +145,7 @@ struct mmc_blk_request {
 static u32 mmc_sd_num_wr_blocks(struct mmc_card *card)
 {
 	int err;
-	u32 blocks;
+	__be32 blocks;
 
 	struct mmc_request mrq;
 	struct mmc_command cmd;
@@ -204,9 +204,7 @@ static u32 mmc_sd_num_wr_blocks(struct mmc_card *card)
 	if (cmd.error || data.error)
 		return (u32)-1;
 
-	blocks = ntohl(blocks);
-
-	return blocks;
+	return ntohl(blocks);
 }
 
 static int mmc_blk_issue_rq(struct mmc_queue *mq, struct request *req)
-- 
1.6.0.3.723.g757e




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mmc: trivial annotation of 'blocks'
  2008-10-23  0:09 [PATCH] mmc: trivial annotation of 'blocks' Harvey Harrison
@ 2008-10-26 11:50 ` Pierre Ossman
  0 siblings, 0 replies; 2+ messages in thread
From: Pierre Ossman @ 2008-10-26 11:50 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: Andrew Morton, LKML

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

On Wed, 22 Oct 2008 17:09:00 -0700
Harvey Harrison <harvey.harrison@gmail.com> wrote:

> sg_init_one is reading a be32, annotate as such.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---

Applied, thanks.

-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-26 11:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-23  0:09 [PATCH] mmc: trivial annotation of 'blocks' Harvey Harrison
2008-10-26 11:50 ` Pierre Ossman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox