Re: Suspend to RAM regression in 2.6.28-rc2 (bisected)

Jens Axboe
2008-10-27T19:14:29Z

On Mon, Oct 27 2008, Johannes Berg wrote:
> On Mon, 2008-10-27 at 20:06 +0100, Jens Axboe wrote:
> > On Mon, Oct 27 2008, Carlos R. Mafra wrote:
> > > On Mon 27.Oct'08 at 19:44:42 +0100, Johannes Berg wrote:
> > > > On Mon, 2008-10-27 at 19:31 +0100, Johannes Berg wrote:
> > > > > On Mon, 2008-10-27 at 19:07 +0100, Soeren Sonnenburg wrote:
> > > > >
> > > > > > > Johannes, can you pls have a look?
> > > > >
> > > > > I did, and I have no idea. Makes no sense at all.
> > > >
> > > > The only thing I can remotely think of is that iwlwifi doesn't like
> > > > being called back from within the call that it did to mac80211, which
> > > > obviously happens here. But I have no idea, the code as it stands is
> > > > correct, just the interaction with iwlwifi's resume seems to be broken.
> > > >
> > > > Try this patch instead:
> > >
> > > Yep, with this patch it also works!
> >
> > Confirmed here as well, my x60 is happy again.
>
> Thanks. Another alternative I could think of is deferring the
> notifications to a work struct, but I'd rather see that in the driver I
> think, not sure though, could be argued either way.

If you want something else tested, just let me know. I don't care a
whole lot about how it gets fixed, as long as it does :-). I use STR
heavily, so it's quite a burden to have it broken.

--
Jens Axboe