From: Joe Perches <joe@perches.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Johannes Berg <johannes@sipsolutions.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/5] net/ipv4, net/ipv6: use %#p6, %p6 format strings
Date: Mon, 27 Oct 2008 22:05:38 -0700 [thread overview]
Message-ID: <1225170338.5269.127.camel@localhost> (raw)
In-Reply-To: <1225166718.5526.18.camel@brick>
On Mon, 2008-10-27 at 21:05 -0700, Harvey Harrison wrote:
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index eea9542..113c4d9 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2986,9 +2986,8 @@ static void if6_seq_stop(struct seq_file *seq, void *v)
> static int if6_seq_show(struct seq_file *seq, void *v)
> {
> struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
> - seq_printf(seq,
> - NIP6_SEQFMT " %02x %02x %02x %02x %8s\n",
> - NIP6(ifp->addr),
> + seq_printf(seq, "%#p6 %02x %02x %02x %02x %8s\n",
> + &ifp->addr,
> ifp->idev->dev->ifindex,
> ifp->prefix_len,
> ifp->scope,
Is it really necessary to change the formats and arguments?
Perhaps it's enough to change the defines to:
#define NIP6_FMT "%6p"
#define NIP6_SEQFMT "%#6p"
#define NIP6(addr) &(addr)
If not, I think the NIP6 and NIP6_SEQFMT should be
separate patchsets for ease of verification.
next prev parent reply other threads:[~2008-10-28 5:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 4:05 [RFC PATCH 3/5] net/ipv4, net/ipv6: use %#p6, %p6 format strings Harvey Harrison
2008-10-28 5:05 ` Joe Perches [this message]
2008-10-28 5:35 ` Harvey Harrison
2008-10-28 5:47 ` Joe Perches
2008-10-28 8:26 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225170338.5269.127.camel@localhost \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox