Re: [RFC][PATCH] lru_add_drain_all() don't use schedule_on_each_cpu()

KOSAKI Motohiro
2008-10-26T13:38:01Z

Hi Peter,

>> @@ -611,4 +613,8 @@ void __init swap_setup(void)
>> #ifdef CONFIG_HOTPLUG_CPU
>> hotcpu_notifier(cpu_swap_callback, 0);
>> #endif
>> +
>> + vm_wq = create_workqueue("vm_work");
>> + BUG_ON(!vm_wq);
>> +
>> }
>
> While I really hate adding yet another per-cpu thread for this, I don't
> see another way out atm.

Can I ask the reason of your hate?
if I don't know it, making improvement patch is very difficult to me.

> Oleg, Rusty, ego, you lot were discussing a similar extra per-cpu
> workqueue, can we merge these two?