Re: [patch 1/7] cpusets: add dirty map to struct address_space

David Rientjes
2008-10-28T19:19:45Z

On Tue, 28 Oct 2008, Peter Zijlstra wrote:

> > @@ -487,6 +488,12 @@ void generic_sync_sb_inodes(struct super_block *sb,
> > continue; /* blockdev has wrong queue */
> > }
> >
> > + if (!cpuset_intersects_dirty_nodes(mapping, wbc->nodes)) {
> > + /* No node pages under writeback */
> > + requeue_io(inode);
> > + continue;
> > + }
>
> So, aside from all the dirty limit and passing node masks around, this
> is the magic bit?
>
> I totally missed it first time around, a short mention in the changelog
> might not be undeserved.
>

Added, thanks.