Re: [patch 3/7] mm: make page writeback obey cpuset constraints

David Rientjes
2008-10-28T19:17:20Z

On Tue, 28 Oct 2008, Peter Zijlstra wrote:

> > +int cpuset_populate_dirty_limits(struct dirty_limits *dl,
> > + unsigned long *dirtyable_memory,
> > + unsigned long *nr_mapped,
> > + const nodemask_t *nodes)
> > +{
> > + int node;
> > +
> > + if (likely(!nodes || nodes_subset(node_online_map, *nodes)))
> > + return 0;
> > + for_each_node_mask(node, *nodes) {
> > + if (!node_online(node))
> > + continue;
> > + dl->nr_dirty += node_page_state(node, NR_FILE_DIRTY);
> > + dl->nr_unstable += node_page_state(node, NR_UNSTABLE_NFS);
> > + dl->nr_writeback += node_page_state(node, NR_WRITEBACK);
> > + dirtyable_memory +=
>
> *dirtyable_memory perhaps?
>

Indeed, fixed.

> > + node_page_state(node, NR_ACTIVE_ANON) +
> > + node_page_state(node, NR_ACTIVE_FILE) +
> > + node_page_state(node, NR_INACTIVE_ANON) +
> > + node_page_state(node, NR_INACTIVE_FILE) +
> > + node_page_state(node, NR_FREE_PAGES);
> > + nr_mapped +=
>
> idem?
>

Likewise.