From: Johannes Berg <johannes@sipsolutions.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
davem@davemloft.net, joe@perches.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/5] iscsi: bugfix for displaying IPv6 address
Date: Mon, 03 Nov 2008 21:20:22 +0100 [thread overview]
Message-ID: <1225743622.3619.67.camel@johannes.berg> (raw)
In-Reply-To: <20081103121600.b3a8eef2.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On Mon, 2008-11-03 at 12:16 -0800, Andrew Morton wrote:
> On Mon, 27 Oct 2008 21:05:17 -0700
> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > Notice that ip is a u8 *, so currently every other byte is
> > being truncated here.
> >
>
> I don't understand that bug description. The code looks OK to me?
> > - str += sprintf(str, NIP6_FMT, ntohs(ip[0]), ntohs(ip[1]),
> > - ntohs(ip[2]), ntohs(ip[3]), ntohs(ip[4]),
> > - ntohs(ip[5]), ntohs(ip[6]), ntohs(ip[7]));
> > + str += sprintf(str, "%p6", ip);
If ip is a u8 * these ntohs are operating on bytes which is bogus, and
NIP6_FMT expects to get 8 u16s, not 8 u8s.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-11-03 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 4:05 [RFC PATCH 2/5] iscsi: bugfix for displaying IPv6 address Harvey Harrison
2008-11-03 20:16 ` Andrew Morton
2008-11-03 20:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225743622.3619.67.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox