public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	kay.sievers@vrfy.org, folkert@vanheusden.com, jacmet@sunsite.dk,
	linux-kernel@vger.kernel.org
Subject: Re: bdi: register sysfs bdi device only once per queue
Date: Wed, 05 Nov 2008 23:21:25 +0100	[thread overview]
Message-ID: <1225923685.7803.3529.camel@twins> (raw)
In-Reply-To: <1225923040.3882.0.camel@macbook.infradead.org>

On Wed, 2008-11-05 at 23:10 +0100, David Woodhouse wrote:
> On Wed, 2008-11-05 at 12:10 -0800, Andrew Morton wrote:
> > > > Devices which share the same queue, like floppies and mtd devices,
> > > > get registered multiple times in the bdi interface, but bdi accounts
> > > > only the last registered device of the devices sharing one queue.
> > > 
> > > David, is there any reason the mtd devices do this?
> > 
> > [tap tap - is this thing turned on?]
> 
> No particular reason. It's been done that way since the dawn of time,
> when it was perfectly normal. Nobody's yet bothered to change that, when
> changing the rules.

I don't think it ever made sense, or was intended that way, but yeah it
didn't really matter in any substantial way.

I can remember touching some mtd stuff back when I did the
per-bdi-writeback stuff, but I can't seem to recall all the details.

Might be time to stare at the mtd code a bit...

  reply	other threads:[~2008-11-05 22:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-03 15:53 bdi: register sysfs bdi device only once per queue Kay Sievers
2008-11-03 16:08 ` Peter Zijlstra
2008-11-05 20:10   ` Andrew Morton
2008-11-05 22:10     ` David Woodhouse
2008-11-05 22:21       ` Peter Zijlstra [this message]
2008-11-07 14:11       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225923685.7803.3529.camel@twins \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=folkert@vanheusden.com \
    --cc=jacmet@sunsite.dk \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox