From: Harvey Harrison <harvey.harrison@gmail.com>
To: Eduard Munteanu <eduard.munteanu@linux360.ro>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
LKML <linux-kernel@vger.kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: [PATCH-ugly] kmemtrace: casting a gfp_t requires __force
Date: Fri, 07 Nov 2008 10:58:41 -0800 [thread overview]
Message-ID: <1226084321.11596.37.camel@brick> (raw)
gfp_t is a bitwise type, casting to unsigned long produces a
warning. Suppress it with __force.
Otherwise sparse complains thusly:
include/linux/kmemtrace.h:33:2: warning: cast from restricted gfp_t
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Eduard, this is a local patch I've had sitting around in my sparse testing
tree. I'm really not sure what the appropriate format specifier is for a
gfp_t, but I don't think the trace infrastructure has support for it
anyway...so if you are going to keep casting to unsigned long you'll need
this...perhaps with a comment why added.
include/linux/kmemtrace.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/kmemtrace.h b/include/linux/kmemtrace.h
index 5bea8ea..9d82085 100644
--- a/include/linux/kmemtrace.h
+++ b/include/linux/kmemtrace.h
@@ -34,7 +34,7 @@ static inline void kmemtrace_mark_alloc_node(enum kmemtrace_type_id type_id,
"bytes_req %lu bytes_alloc %lu gfp_flags %lu node %d",
type_id, call_site, (unsigned long) ptr,
(unsigned long) bytes_req, (unsigned long) bytes_alloc,
- (unsigned long) gfp_flags, node);
+ (__force unsigned long)gfp_flags, node);
}
static inline void kmemtrace_mark_free(enum kmemtrace_type_id type_id,
--
1.6.0.3.756.gb776d
next reply other threads:[~2008-11-07 18:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 18:58 Harvey Harrison [this message]
2008-11-07 19:20 ` [PATCH-ugly] kmemtrace: casting a gfp_t requires __force Alexey Dobriyan
2008-11-07 19:22 ` Harvey Harrison
2008-11-07 19:38 ` Mathieu Desnoyers
2008-11-07 19:50 ` Harvey Harrison
2008-11-07 20:41 ` Alexey Dobriyan
2008-11-07 22:50 ` Eduard - Gabriel Munteanu
2008-11-07 23:08 ` Mathieu Desnoyers
2008-11-07 23:25 ` Alexey Dobriyan
2008-11-07 23:05 ` Eduard - Gabriel Munteanu
2008-11-07 23:06 ` Eduard - Gabriel Munteanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226084321.11596.37.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=adobriyan@gmail.com \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox