From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754766AbYKMX5s (ORCPT ); Thu, 13 Nov 2008 18:57:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751854AbYKMX5j (ORCPT ); Thu, 13 Nov 2008 18:57:39 -0500 Received: from ozlabs.org ([203.10.76.45]:34934 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbYKMX5i (ORCPT ); Thu, 13 Nov 2008 18:57:38 -0500 Subject: Re: [PATCH] Store the relevant miscdevice in file->private_data in misc_open() From: Michael Ellerman Reply-To: michael@ellerman.id.au To: Greg KH Cc: linux-kernel@vger.kernel.org, Andrew Morton , viro@zeniv.linux.org.uk In-Reply-To: <20081113173127.GB30811@kroah.com> References: <20081113173127.GB30811@kroah.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-SHv6lGynNv5N6wstqqc4" Date: Fri, 14 Nov 2008 10:54:41 +1100 Message-Id: <1226620481.8066.18.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-SHv6lGynNv5N6wstqqc4 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2008-11-13 at 09:31 -0800, Greg KH wrote:=20 > On Thu, Nov 13, 2008 at 03:49:50PM +1100, Michael Ellerman wrote: > > Currently it's not easy to share file_operations between multiple > > instances of a miscdevice. In order to do this, the device code needs t= o > > store a list of all it's miscdevice instances, and when fops->open() is > > called, search the list and find the right device based on the minor > > number. > >=20 > > However the generic miscdevice code already has a list of miscdevices, > > and uses this to find the right device in misc_open(). If misc_open() > > would store the miscdevice it found in file->private_data, then the > > device code wouldn't need to worry about storing it's own separate list > > and searching that as well. > >=20 > > The rest of the miscdevice code does not use file->private_data, so the > > device code is still free to use file->private_data for something else > > if it wants to. > >=20 > > Signed-off-by: Michael Ellerman >=20 > Do you have a follow-on patch for some misc device using code that would > take advantage of this change? Ah, good point. I do, but not for upstream :/ cheers --=20 Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person --=-SHv6lGynNv5N6wstqqc4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkkcvkEACgkQdSjSd0sB4dJt/QCeJKpSWDBNzeWjw8ZWrLoDoScb mTcAoLxTeZN7Szs0rOVN6hvrHi61UXM+ =HEQ8 -----END PGP SIGNATURE----- --=-SHv6lGynNv5N6wstqqc4--