From: Harvey Harrison <harvey.harrison@gmail.com>
To: Michael Krufky <mkrufky@linuxtv.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
v4l-maintainer <v4l-dvb-maintainer@linuxtv.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v4l-dvb-maintainer] [PATCH] dvb: usb vendor_ids/product_ids are __le16
Date: Fri, 14 Nov 2008 11:07:49 -0800 [thread overview]
Message-ID: <1226689669.5483.36.camel@brick> (raw)
In-Reply-To: <491DCBDD.4000703@linuxtv.org>
On Fri, 2008-11-14 at 14:05 -0500, Michael Krufky wrote:
> Wouldn't it be nicer to just switch on
> cpu_to_le16(udev->descriptor.idVendor) ? This would be a 1-line change,
> compile to a smaller footprint, and be easier to read.
>
> Personally, I prefer to try to avoid duplicating code in places where a
> single operation may occur centrally.
On a little-endian arch it makes no difference obviously, but on a
big-endian arch it's the difference between compile-time and runtime
byteswapping.
Harvey
next prev parent reply other threads:[~2008-11-14 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 18:19 [PATCH] dvb: usb vendor_ids/product_ids are __le16 Harvey Harrison
2008-11-14 19:05 ` [v4l-dvb-maintainer] " Michael Krufky
2008-11-14 19:07 ` Harvey Harrison [this message]
2008-11-14 19:15 ` Michael Krufky
2008-11-14 19:20 ` Harvey Harrison
2008-11-14 19:25 ` Devin Heitmueller
2008-11-14 19:44 ` Harvey Harrison
2008-11-14 20:55 ` Andy Walls
2008-11-14 21:08 ` Harvey Harrison
2008-11-15 10:42 ` Hans Verkuil
2008-11-15 7:21 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226689669.5483.36.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mkrufky@linuxtv.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox