From: Markus Metzger <markus.t.metzger@googlemail.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: work <markus.t.metzger@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
stephane eranian <eranian@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Subject: [patch] x86, bts: fix unlock problem in ds.c
Date: Sat, 15 Nov 2008 11:00:17 +0100 [thread overview]
Message-ID: <1226743217.6162.4.camel@raistlin> (raw)
Fix a problem where ds_request() returned an error without releasing the
ds lock.
Reported-by: Stephane Eranian <eranian@gmail.com>
Signed-off-by: Markus Metzger <markus.t.metzger@gmail.com>
---
Index: gits/arch/x86/kernel/ds.c
===================================================================
--- gits.orig/arch/x86/kernel/ds.c 2008-11-15 10:51:51.000000000 +0100
+++ gits/arch/x86/kernel/ds.c 2008-11-15 10:53:43.000000000 +0100
@@ -384,8 +384,9 @@
spin_lock(&ds_lock);
+ error = -EPERM;
if (!check_tracer(task))
- return -EPERM;
+ goto out_unlock;
error = -ENOMEM;
context = ds_alloc_context(task);
next reply other threads:[~2008-11-15 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 10:00 Markus Metzger [this message]
2008-11-16 7:26 ` [patch] x86, bts: fix unlock problem in ds.c Ingo Molnar
2008-11-20 21:14 ` stephane eranian
2008-11-20 21:48 ` Ingo Molnar
2008-11-20 22:06 ` stephane eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226743217.6162.4.camel@raistlin \
--to=markus.t.metzger@googlemail.com \
--cc=eranian@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@intel.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox