Re: [PATCH] Fix writing to trace/trace_options

Ingo Molnar
2008-11-17T11:18:15Z

* Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> wrote:

> On Sun, Nov 16, 2008 at 04:07:58PM +0530, Aneesh Kumar K.V wrote:
> > writing to trace/trace_options use the index of the array
> > to find the value of the flag. With branch tracer flag
> > defined conditionally, this breaks writing to trace_options
> > with branch tracer disabled.
> >
> > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> tg export didn't add numbering to the patch based on dependency.
> So the series is in the below order
>
> [PATCH] ftrace: add proper bin iterator support
> [PATCH] ftrace: Add dump iteator
> [PATCH] ftrace: Add debug_print trace to print data from kernel to userspace
> [PATCH] ftrace: Add new entry type TRACE_BIN_DUMP
> [PATCH] ftrace: Add debug_dump trace to dump binary data from kernel to userspace
> [PATCH] Fix writing to trace/trace_options
>
> The patches are against -tip with HEAD
> 7195b6707adcd00f413ce07e6b9954b4c597495c

hm, i'm not sure about this. We already do binary dumping, but only
for the cases where we actually know the structure of the data (i.e.
binary dumping is just an output format, not a tracing type). And that
is good so.

In your patchset right now nothing uses debug_dump(ptr, len) so it's
hard to see exactly how we should shape it. What specific usages do
you have in mind?

Ingo