From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Geliang Tang <geliangtang@163.com>, Sekhar Nori <nsekhar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] ARM: davinci: fix a problematic usage of WARN()
Date: Wed, 25 Nov 2015 14:39:44 +0100 [thread overview]
Message-ID: <12268783.CeI9Q9YHFN@wuerfel> (raw)
In-Reply-To: <06d69890c56bd84a831a1dccee26e34b4988a241.1448456395.git.geliangtang@163.com>
On Wednesday 25 November 2015 21:12:19 Geliang Tang wrote:
> +++ b/arch/arm/mach-davinci/board-dm355-evm.c
> @@ -385,7 +385,7 @@ static __init void dm355_evm_init(void)
>
> aemif = clk_get(&dm355evm_dm9000.dev, "aemif");
> if (IS_ERR(aemif))
> - WARN("%s: unable to get AEMIF clock\n", __func__);
> + WARN(1, "%s: unable to get AEMIF clock\n", __func__);
> else
> clk_prepare_enable(aemif);
>
>
How about writing this as
if (!WARN(IS_ERR(aemif)), "unable to get AEMIF clock\n"))
clk_prepare_enable(aemif);
Note that WARN() already contains file and line, so you don't really
need the __func__ here either.
Arnd
next prev parent reply other threads:[~2015-11-25 13:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 13:12 [PATCH 1/7] drm/msm/mdp: fix a problematic usage of WARN_ON() Geliang Tang
2015-11-25 13:12 ` [PATCH 2/7] drm/vmwgfx: " Geliang Tang
2015-11-25 13:12 ` [PATCH 3/7] iio: " Geliang Tang
2015-11-25 13:12 ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Geliang Tang
2015-11-25 13:12 ` [PATCH 5/7] vfio: fix a problematic usage of WARN() Geliang Tang
2015-11-25 13:12 ` [PATCH 6/7] ARM: davinci: " Geliang Tang
2015-11-25 13:12 ` [PATCH 7/7] powerpc: " Geliang Tang
2015-11-26 5:25 ` Michael Ellerman
2015-11-25 13:39 ` Arnd Bergmann [this message]
2015-11-25 14:13 ` [PATCH v2] ARM: davinci: " Geliang Tang
2015-11-25 20:21 ` kbuild test robot
2015-11-25 20:28 ` Arnd Bergmann
2015-11-26 0:35 ` [PATCH v3] " Geliang Tang
2015-12-15 9:58 ` Sekhar Nori
2015-11-25 13:35 ` [PATCH 5/7] vfio: " Alex Williamson
2015-11-25 13:47 ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Grumbach, Emmanuel
2015-11-25 13:14 ` [PATCH 3/7] iio: fix a problematic usage of WARN_ON() Lars-Peter Clausen
2015-11-25 15:50 ` [PATCH 2/7] drm/vmwgfx: " Sinclair Yeh
2015-11-26 14:51 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12268783.CeI9Q9YHFN@wuerfel \
--to=arnd@arndb.de \
--cc=geliangtang@163.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox