public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Chris Friesen <cfriesen@nortel.com>
Cc: Ken Chen <kenchen@google.com>, Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: busted CFS group load balancer?
Date: Tue, 18 Nov 2008 06:19:08 +0100	[thread overview]
Message-ID: <1226985548.29743.6.camel@lappy.programming.kicks-ass.net> (raw)
In-Reply-To: <4921DFD8.9060509@nortel.com>

On Mon, 2008-11-17 at 15:19 -0600, Chris Friesen wrote:
> Ken Chen wrote:
> > On Mon, Nov 17, 2008 at 7:37 AM, Chris Friesen wrote:
> >>> It appears that the fair-group load balancer in 2.6.27 does not work
> >>> properly.
> >> There was an issue fixed post 2.6.27 where the load balancer didn't work
> >> properly if there was one task per group per cpu.  You might try
> >> backporting commit 38736f4 and see if that helps.
> > 
> > Tested git commit 38736f4, it doesn't fix the problem I'm seeing.
> > 
> 
> I plugged in the same weights into my test app (groups 1 and 2 instead 
> of ant/bee) and got the results below for a 10-sec run.  The "actual" 
> numbers give the overall average and then the values for each hog 
> separately.  In this case we see that both tasks in group 2 ended up 
> sharing a cpu with one of the tasks from group 1.
> 
>    group      actual(%)      expected(%)  ctx switches   max_latency(ms)
>        1  99.69(99.38/99.99)   99.81       160/262          4/0
>        2   0.31( 0.31/0.31)     0.19       32/33         391/375
> 
> I've only got a 2-way system.  If the results really are that much worse 
> on larger systems, then that's going to cause problems for us as well. 
> I'll see if I can get some time on a bigger machine.

Note that with larger cpu count and/or lower group weight we'll quickly
run into numerical trouble...

I would recommend trying this with the minimum weight in the order of
8-16 times number of cpus on your system.

There is only so much one can do with 10 bit fixed precision math :/



  reply	other threads:[~2008-11-18  5:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-15  1:14 busted CFS group load balancer? Ken Chen
2008-11-17 15:37 ` Chris Friesen
2008-11-17 20:04   ` Ken Chen
2008-11-17 21:19     ` Chris Friesen
2008-11-18  5:19       ` Peter Zijlstra [this message]
2008-11-18  7:33         ` Ken Chen
2008-11-18 12:30           ` Peter Zijlstra
2008-11-18 13:48             ` Peter Zijlstra
2008-11-18 17:27             ` Ken Chen
2008-11-18  7:52     ` Ken Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226985548.29743.6.camel@lappy.programming.kicks-ass.net \
    --to=a.p.zijlstra@chello.nl \
    --cc=cfriesen@nortel.com \
    --cc=kenchen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox