Re: [PATCH 07/16] Blackfin SPI Driver: drop bogus cast and touchup dma label

David Brownell
2008-11-20T20:53:47Z

On Monday 17 November 2008, Bryan Wu wrote:
> From: Mike Frysinger <vapier.adi@gmail.com>
>
> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>

Acked-by: David Brownell <dbrownell@users.sourceforge.net>

... again, please to include real patch comments
not just long $SUBJECT lines

> ---
> drivers/spi/spi_bfin5xx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c
> index df424a2..a7c8976 100644
> --- a/drivers/spi/spi_bfin5xx.c
> +++ b/drivers/spi/spi_bfin5xx.c
> @@ -1076,13 +1076,13 @@ static int setup(struct spi_device *spi)
> */
> if (chip->enable_dma && !drv_data->dma_requested) {
> /* register dma irq handler */
> - if (request_dma(drv_data->dma_channel, "BF53x_SPI_DMA") < 0) {
> + if (request_dma(drv_data->dma_channel, "BFIN_SPI_DMA") < 0) {
> dev_dbg(&spi->dev,
> "Unable to request BlackFin SPI DMA channel\n");
> return -ENODEV;
> }
> if (set_dma_callback(drv_data->dma_channel,
> - (void *)dma_irq_handler, drv_data) < 0) {
> + dma_irq_handler, drv_data) < 0) {
> dev_dbg(&spi->dev, "Unable to set dma callback\n");
> return -EPERM;
> }
> --
> 1.5.6.3
>
>