From: Keith Owens <kaos@ocs.com.au>
To: george@mvista.com
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NMI watch dog notify patch
Date: Sat, 30 Jul 2005 13:24:51 +1000 [thread overview]
Message-ID: <12270.1122693891@ocs3.ocs.com.au> (raw)
In-Reply-To: Your message of "Fri, 29 Jul 2005 13:55:23 MST." <42EA97BB.8020001@mvista.com>
On Fri, 29 Jul 2005 13:55:23 -0700,
George Anzinger <george@mvista.com> wrote:
> This patch adds a notify to the die_nmi notify that the system
> is about to be taken down. If the notify is handled with a
> NOTIFY_STOP return, the system is given a new lease on life.
>
> void die_nmi (struct pt_regs *regs, const char *msg)
> {
>+ if (notify_die(DIE_NMIWATCHDOG, "nmi_watchdog", regs,
>+ 0, 0, SIGINT) == NOTIFY_STOP)
>+ return;
>+
> spin_lock(&nmi_print_lock);
> /*
> * We are in trouble anyway, lets at least try
Minor nitpick. die_nmi() already gets a message passed in to
distinguish between different types of nmi. Pass that message to
notify_die(), on the off chance that the notified routines can use that
difference.
Also your patch adds a trailing whitespace on the call to notify_die().
next prev parent reply other threads:[~2005-07-30 3:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-28 20:31 [PATCH] NMI watch dog notify patch George Anzinger
2005-07-28 23:13 ` Andrew Morton
2005-07-28 23:58 ` George Anzinger
2005-07-29 0:12 ` Andrew Morton
2005-07-29 1:50 ` Keith Owens
2005-07-29 4:16 ` George Anzinger
2005-07-29 5:09 ` Keith Owens
2005-07-29 5:14 ` Andrew Morton
2005-07-29 20:55 ` George Anzinger
2005-07-30 3:24 ` Keith Owens [this message]
2005-08-01 22:58 ` George Anzinger
2005-08-02 20:26 ` [PATCH] " George Anzinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12270.1122693891@ocs3.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=akpm@osdl.org \
--cc=george@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox